1606932 - Accessible focus not fired after dismissing OS open and save dialogs

Status: VERIFIED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[elliottabarnes]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:71.0) Gecko/20100101 Firefox/71.0

Steps to reproduce:

To reproduce - tested with Firefox 71 X64 on Windows 7 with NVDA 2019.2.1 whilst performing all of the following with the keyboard:

1. With NVDA running, navigate to any web page that has a linked file, and place NVDA's focus on the link

2. Press shift + F10 to invoke the right-click context menu, and select "Save Link As..."

3. Select any location, and hit the "Save" button - this will close the "Save As" dialog, and return focus to the previous browser window

4. Finally, attempt to use the arrow keys to continue navigating the page content

Actual results:

When hitting any of the arrow keys after following the above steps, nothing happens - NVDA's focus doesn't move.

Expected results:

When pressing any of the cursor keys, NVDA should move around the page - as was possible before opening "Save As". The only way to force navigation is to either tab or shift tab.

Comment 1

[Clara Guerrero ( Need Info Brindusa Tot Please)]

Hi Elliot,

Thanks for the details. I was able to reproduce on Windows 10 pro, using NVDA 2019.2.1 , on the following versions

Firefox Nightly version74.0a1 (2020-01-07) (64-bit),
Beta 73.015 (64-bit)
Release 72.0 (64-bit)

This happens just the first time, correct? After forcing navigation with either tab or shift tab, and following the same steps, then it won't keep happening.

I've updated the component to Keyboard navigation so that the issue is reviewed by the development team. (If this is not the correct component feel free to change it for a more suitable one)

Best regards, Clara.

Comment 2

[Dão Gottwald [:dao]]

I can't seem to reproduce this on Ubuntu (i.e. no NVDA). Is this Windows-specific, or NVDA-specific? Moving to Disability Access for now.

Comment 3

[elliottabarnes]

This is correct - using either tab/shift + tab restores navigation as expected.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:asa, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[James Teh [:Jamie]]

This was fixed for the print dialog in bug 782547. I had hoped this would fix it for all OS modal dialogs, but apparently not.

It's likely that this will need to be fixed in the Windows widget code, but I'll put this in disability access APIs, since it only seems to hurt a11y.

Comment 6

[James Teh [:Jamie]]

Oh. The reason is that blur events get suppressed for file chooser dialogs, but not print dialogs. That's why the original patch for bug 782547 removed the blur suppression code. That destabilised Flash for some reason (bug 782547 comment 11), so it got backed out. The patch recently landed did not remove the blur suppression code because it was suspected that this was the reason for the backout. I'm now not convinced this is true, since the only place this blur suppression code gets used is browser file chooser dialogs, not in the plugin support. Anyway, Flash on Youtube is no longer a thing.

The blur suppression code was originally added in bug 68454 to fix a crash when bringing up a file chooser dialog from the context menu on a window which calls self.close() on blur. However, Neil wasn't able to reproduce this crash any more with the blur suppression code removed (bug 782547 comment 5). I've likewise tested this and I can't reproduce it.

So, I think we should try removing this again.

Comment 7

[James Teh [:Jamie]]

Attachment: Bug 1606932: Don't suppress blur events for file picker dialogs on Windows.

Suppressing blur events prevents accessibility from firing focus events correctly when dismissing file picker dialogs.
This code was originally added in bug 68454 to fix a crash when bringing up a file picker dialog from the context menu on a window which calls self.close() on blur.
However, this crash can no longer be reproduced, so the code isn't needed any more.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/175db8ba16d9
Don't suppress blur events for file picker dialogs on Windows. r=NeilDeakin

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/175db8ba16d9

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider uplifting to Beta for 74 or can this fix ride 75 to release?

Comment 11

[James Teh [:Jamie]]

I'd love to uplift it - it's a pretty annoying bug - but given that it touches Windows code that is 17 years old, I think we should let it bake for a while.

Comment 12

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue on Windows 10x64 with Firefox 73.0a1(20200103202240).
The issue is verified fixed with Firefox 75.0b7 (20200322132212) on Windows 10x64.