1607049 - Refactor LengthPercentage to move the calc() variant to the heap.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Description

[Emilio Cobos Álvarez [:emilio]]

This is a pre-requisite to implement min() / max() / clamp() / etc, as those need to be a tree.

I split this in three logically separate patches that can land independently (but probably should land together).

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1607049 - Split LengthPercentage again. r=#style

This is needed to support min() / max() / clamp(), etc, as those need to be a
tree of values and thus need heap storage.

This unfortunately grows LengthPercentage to be two pointers, which is bad as
it blows up the size of nsStylePosition enough to trigger the size assertions.

This patch comments out the assertion for now, the follow-up patches will
uncomment them.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1607049 - Move LengthPercentage to its own file. r=#style

I'm (sadly) about to make it a bit more complicated to pack it better. So we
may as well do this so it is easier to reason about navigate.

I also reordered things a bit, and removed some From<> implementations and
such.

Depends on D58700

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1607049 - Pack LengthPercentage better. r=#style

So that it takes one pointer instead of two, and doesn't make nsStylePosition's
size blow up.

This is not as ugly as I was fearing, thankfully, though it requires a bit of
boilerplate. I think it's acceptable.

Depends on D58701

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Android: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4545a62c6182fccf511ef2972860e1756d56422e
Linux64: https://treeherder.mozilla.org/#/jobs?repo=try&revision=15ad2b4150a50bfc98073816d36ff1d4da2f5d0c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f9f0e35673f
Split LengthPercentage again. r=boris
https://hg.mozilla.org/integration/autoland/rev/fc566d077b07
Move LengthPercentage to its own file. r=jwatt
https://hg.mozilla.org/integration/autoland/rev/4312c783d434
Pack LengthPercentage better. r=jwatt

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4f9f0e35673f
https://hg.mozilla.org/mozilla-central/rev/fc566d077b07
https://hg.mozilla.org/mozilla-central/rev/4312c783d434