1607121 - TypeError: environment can only contain strings

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect, P2)

Description

[Brian Birtles (:birtles)]

Attachment: wpt.log

Running ./mach wpt ... on Windows gives me TypeError: environment can only contain strings but it previously used to work. Log attached.

Being on Japanese Windows it's entirely possible I have some non-Latin characters in environment variables but I don't see which ones yet.

Bug 1603557 describes some similar circumstances.

Perhaps certutil needs to use env=ensure_subprocess_env(env)?

I'm not entirely sure if this is a regression or not since although it used to work, it's possible it's my environment that has changed.

I'm going to switch to writing a Gecko-specific crashtest for now and update to a wpt crashtest later once I can get this to run.

Comment 1

[James Graham [:jgraham]]

Attachment: Bug 1607121 - Ensure that subprocess environments use correct datatype,

Comment 2

[James Graham [:jgraham]]

I ported the ensure_subprocess_env function to wpt; can you test if it actually solves the issue for you?

Comment 3

[Brian Birtles (:birtles)]

(In reply to James Graham [:jgraham] from comment #2)

I ported the ensure_subprocess_env function to wpt; can you test if it actually solves the issue for you?

Yes, that works! Thank you!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c900ade874f7
Ensure that subprocess environments use correct datatype, r=ato

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21067 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/21067
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/UVXUTpTsQem_l9YAiafJOQ)

Comment 8

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c900ade874f7

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/21067
* Community-TC (pull_request) (https://community-tc.services.mozilla.com/tasks/groups/Z6as_K1eTfm2nE5F52musQ)

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham

Comment 11

[Josh Matthews [:jdm]]

marmedelama points out the following (https://github.com/web-platform-tests/wpt/commit/7a99c5628fa0729330eea64af452ae4c5f93598e#r36904078):

six.ensure_string does not exist, but six.ensure_str does I think its just a typo but code seems to be commited by a bot. Should i fix it "manually" or does it need to be fixed upstream?

Comment 12

[James Graham [:jgraham]]

Commented on the PR; fixes anywhere are acceptable.