1607143 - mermaid js code cannot be loaded (csp issue)

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Documentation, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

Attachment: image.png

https://firefox-source-docs.mozilla.org/tools/docs/mermaid-integration.html

it works locally

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Shivam, rings a bell?

Comment 2

[Shivam Singhal [ :championshuttler ]]

Its weird! , working locally for me as well, I found this https://gitlab.com/gitlab-org/gitlab-foss/issues/47842, we might need to remove the extra lines and push to production , may be after that it might work or push to try ;), cc'ing ahal to just inform him ;)

Comment 3

[Shivam Singhal [ :championshuttler ]]

Cleared ni by mistake, keeping it to just make me remember about it.

Comment 4

[Shivam Singhal [ :championshuttler ]]

Attachment: Bug 1607143 - Attempt to fix Mermaid CSP Issue.r=sylvestre

Comment 5

[Andrew Halberstadt [:ahal]]

Looks like the page in comment 0 doesn't exist anymore? There aren't any uses of mermaid now that I can see.

At any rate, you can test changes on try by running:

./mach try fuzzy -q "'doc-upload"

And then waiting for the task to finish and inspecting the docs at this URL:
http://gecko-docs.mozilla.org-l1.s3.us-west-2.amazonaws.com/index.html

Comment 6

[Sylvestre Ledru [:Sylvestre]]

https://github.com/mgaitan/sphinxcontrib-mermaid/pull/37

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1607143 - Doc: run some post processing code to fix the url to mermaid js r?#firefox-source-docs-reviewers,championshuttler

Also bump to the latest version of mermaid js

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1607143 - Ride along - Remove a useless declaration and add an empty line r?championshuttler

Depends on D62027

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/681191363d89
Doc: run some post processing code to fix the url to mermaid js r=championshuttler
https://hg.mozilla.org/integration/autoland/rev/feb498df8a2e
Ride along - Remove a useless declaration and add an empty line r=championshuttler

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/681191363d89
https://hg.mozilla.org/mozilla-central/rev/feb498df8a2e