Set background rate and fallback for automated betas
Categories
(Release Engineering :: Release Automation, enhancement)
Tracking
(firefox73 fixed, firefox74 fixed)
People
(Reporter: Callek, Assigned: Callek)
Details
Attachments
(3 files)
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
63 bytes,
text/x-github-pull-request
|
Details | Review |
Assignee | ||
Comment 1•5 years ago
|
||
https://phabricator.services.mozilla.com/D56801
Depends on D58646
Updated•5 years ago
|
Comment 3•5 years ago
|
||
bugherder |
Comment 4•5 years ago
|
||
Comment on attachment 9118885 [details]
Bug 1607266 - Set background rate and fallback for automated beta's. r=mtabara
Beta/Release Uplift Approval Request
- User impact if declined: None. This is an automation change in order to regulate the background/fallback rates for b1-b2-b3 so that RelMan no longer has to do it.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Not risky.
- String changes made/needed:
Comment 5•5 years ago
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9119170 [details]
Bug 1607266 - devedition should set no backgroundRate. r=bhearsum
Beta/Release Uplift Approval Request
- User impact if declined: None. Automation follow-up fix to my previous patch to make sure Devedition doesn't set a background rate.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1607266
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
Comment 8•5 years ago
|
||
Comment on attachment 9118885 [details]
Bug 1607266 - Set background rate and fallback for automated beta's. r=mtabara
Automatically set the update rate for the early betas. Approved for 73.0b2.
Updated•5 years ago
|
Comment 9•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/0b1cde02d80a
https://hg.mozilla.org/releases/mozilla-beta/rev/224a9d594b0d
Comment 10•5 years ago
•
|
||
I think there is a bug in this.
We make the new payload vars optional: https://hg.mozilla.org/releases/mozilla-beta/rev/0b1cde02d80a#l2.71
But we expect them to exist: https://github.com/mozilla-releng/scriptworker-scripts/pull/116/files#diff-c94ab011a5da8654fdb1da7508514dbdR101
see logs:
notice devedition and beta complain about having opposite payload vars missing: force_fallback_mapping_update
and background_rate
Comment 11•5 years ago
|
||
(In reply to Jordan Lund (:jlund) from comment #10)
But we expect them to exist: https://github.com/mozilla-releng/scriptworker-scripts/pull/116/files#diff-c94ab011a5da8654fdb1da7508514dbdR101
I suspect we want to update balrogscript to allow these new payload options as optional. e.g. .get() rather than an expected key via []
But I'm unfamiliar with the patches and the expected behaviour.
Comment 12•5 years ago
|
||
I force ran the deps of this task and manually did the balrog steps so we are unblocked for beta2 but need to fix for beta3 and later
Comment 13•5 years ago
|
||
I'll take care of these once releaes are out. Thanks for raising.
Comment 14•5 years ago
|
||
bugherder |
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
https://github.com/mozilla-releng/scriptworker-scripts/pull/131 landed to production, we should no longer see these issues on beta.
Updated•2 months ago
|
Description
•