Closed Bug 1607266 Opened 5 years ago Closed 5 years ago

Set background rate and fallback for automated betas

Categories

(Release Engineering :: Release Automation, enhancement)

enhancement
Not set
normal

Tracking

(firefox73 fixed, firefox74 fixed)

RESOLVED FIXED
Tracking Status
firefox73 --- fixed
firefox74 --- fixed

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(3 files)

No description provided.
Assignee: nobody → bugspam.Callek
Status: NEW → ASSIGNED
Pushed by mtabara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6d30459c4f5 Set background rate and fallback for automated beta's. r=mtabara
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

Comment on attachment 9118885 [details]
Bug 1607266 - Set background rate and fallback for automated beta's. r=mtabara

Beta/Release Uplift Approval Request

  • User impact if declined: None. This is an automation change in order to regulate the background/fallback rates for b1-b2-b3 so that RelMan no longer has to do it.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky.
  • String changes made/needed:
Attachment #9118885 - Flags: approval-mozilla-beta?
Pushed by mtabara@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a9997966d171 devedition should set no backgroundRate. r=bhearsum

Comment on attachment 9119170 [details]
Bug 1607266 - devedition should set no backgroundRate. r=bhearsum

Beta/Release Uplift Approval Request

  • User impact if declined: None. Automation follow-up fix to my previous patch to make sure Devedition doesn't set a background rate.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: Bug 1607266
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky):
  • String changes made/needed:
Attachment #9119170 - Flags: approval-mozilla-beta?

Comment on attachment 9118885 [details]
Bug 1607266 - Set background rate and fallback for automated beta's. r=mtabara

Automatically set the update rate for the early betas. Approved for 73.0b2.

Attachment #9118885 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9119170 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

(In reply to Jordan Lund (:jlund) from comment #10)

But we expect them to exist: https://github.com/mozilla-releng/scriptworker-scripts/pull/116/files#diff-c94ab011a5da8654fdb1da7508514dbdR101

I suspect we want to update balrogscript to allow these new payload options as optional. e.g. .get() rather than an expected key via []

But I'm unfamiliar with the patches and the expected behaviour.

I force ran the deps of this task and manually did the balrog steps so we are unblocked for beta2 but need to fix for beta3 and later

I'll take care of these once releaes are out. Thanks for raising.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED

https://github.com/mozilla-releng/scriptworker-scripts/pull/131 landed to production, we should no longer see these issues on beta.

Component: Release Automation: Updates → Release Automation
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: