Closed Bug 1607268 Opened 1 month ago Closed 13 days ago

Implement CSSStyleSheet ReplaceSync() Functionality

Categories

(Core :: DOM: CSS Object Model, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

The Constructable StyleSheets API was added under a preference in bug 1604296.

This patch aims to fully implement and test the functionality of the CSSStyleSheet replaceSync() function, which is currently a stub.

Attachment #9118996 - Attachment description: Bug 1607268 - Implement replaceSync() Functionality -- WIP → Bug 1607268 - Implement replaceSync() Functionality r=#style,emilio
Attachment #9118996 - Attachment description: Bug 1607268 - Implement replaceSync() Functionality r=#style,emilio → Bug 1607268 - Implement replaceSync() Functionality -- WIP
Blocks: 1608488
Attachment #9118996 - Attachment description: Bug 1607268 - Implement replaceSync() Functionality -- WIP → Bug 1607268 - Implement replaceSync() Functionality r=#style,emilio
Attachment #9118996 - Attachment description: Bug 1607268 - Implement replaceSync() Functionality r=#style,emilio → Bug 1607268 - Implement replaceSync() Functionality -- WIP
Attachment #9118996 - Attachment description: Bug 1607268 - Implement replaceSync() Functionality -- WIP → Bug 1607268 - Implement replaceSync() Functionality r=emilio

:nordzilla , patch failed to land:
"Revisions: D58881 diff 217836
Details: hg error in cmd: hg push -r tip upstream: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 7 changes to 7 files remote: remote: ******************************* ERROR ******************************* remote: Changeset 60e2760d7001 alters WebIDL file(s) without DOM peer review: remote: dom/webidl/CSSStyleSheet.webidl remote: remote: Please, request review from either: remote: - Andrea Marchesini (:baku) remote: - Andreas Farre (:farre) remote: - Andrew McCreight (:mccr8) remote: - Bobby Holley (:bholley) remote: - Boris Zbarsky (:bz) remote: - Ehsan Akhgari (:ehsan) remote: - Henri Sivonen (:hsivonen) remote: - Nika Layzell (:mystor) remote: - Olli Pettay (:smaug) remote: - Peter Van der Beken (:peterv) remote: ********************************************************************* remote: remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.mozhooks hook failed abort: push failed on remote "

Flags: needinfo?(enordin)
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c23316f9fe83
Implement replaceSync() Functionality r=emilio,bzbarsky
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21176 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Patch failed to land because I had made a minor change to the WebIDL interface USVString -> UTF8String.

I had forgotten that all WebIDL changes must have WebIDL review. Emilio is not yet recognized by the web hook Bug 1609141

This patch has since had it's WebIDL portion reviewed and should be clear to move forward.

Flags: needinfo?(enordin)
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.