Closed Bug 1607322 Opened 7 months ago Closed 4 months ago

Enable Webrender for Pixel 2 and 3 on Release Channel

Categories

(Core :: Graphics: WebRender, task, P2)

74 Branch
task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox74 --- wontfix
firefox75 --- wontfix
firefox76 + fixed
firefox77 + fixed

People

(Reporter: ktaeleman, Assigned: ktaeleman)

References

(Blocks 1 open bug)

Details

(Whiteboard: wr-android)

Attachments

(1 file)

No description provided.

We won't enable webrender for more devices until Fenix has launched, this will most likely be pushed out to 76.

Blocks: wr-75-android
No longer blocks: wr-74-android
Blocks: wr-android
Whiteboard: wr-android
No longer blocks: wr-75-android
Summary: Enable Webrender for Adreno 5xx and 6xx on Release Channel → Enable Webrender for Pixel 2 and 3 on Release Channel
Assignee: nobody → ktaeleman
Status: NEW → ASSIGNED
Pushed by ktaeleman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/22494e2b7ee0
Enable webrender for Pixel 2/3 on release r=jnicol
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77

Comment on attachment 9140587 [details]
Bug 1607322 - Enable webrender for Pixel 2/3 on release

Beta/Release Uplift Approval Request

  • User impact if declined: None
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change only affects Fenix beta release and was enabled before after being disabled for the old short launch window. With the new launch window (date TBD), we have agreement to enable it again from Fenix.
  • String changes made/needed: None
Attachment #9140587 - Flags: approval-mozilla-beta?

Note that Focus is also shipping with release GeckoView. Are we OK with this riding to those users?

Flags: needinfo?(ktaeleman)

Thanks for bringing that to my attention. I've talked to Stefan Arentz and we are ok with it getting enabled on Focus.

Flags: needinfo?(ktaeleman)
Attachment #9140587 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Hi, I have taken a look at a geckoview_example.apk downloaded from Comment8 with Google Pixel 3 XL (Android 9) for the below scenarios and it works ok, but there is a problem a problem when webrender is enabled for the animated slides, more info in notes:

  • Webrender is enabled by default in about:support
  • Webrender can be turned on/off in about:config -> gfx.webrender.force-disabled
  • Verified some flash games and a couple of alexa top sites
  • Animated slides - http://www.playmag.fr/heroesoftomorrow

Note:

  • When checking animated slides as the one's from: http://www.playmag.fr/heroesoftomorrow , with default setting for webrender/enabled, the animation for the first slide does not start, until navigating to the next slide and returning to the first one. Please check video
  • When webrender is disabled through gfx.webrender.force-disabled set to true the objects from the animated slides start as black http://www.playmag.fr/heroesoftomorrow and after navigating through a couple of them do they return to normal.
Flags: qe-verify+

I think that's just autoplay preventing the video from playing. And webrender displays the first frame of the video whereas non-webrender displays black.

Hi, yes after I enabled autoplay, it works ok, video starts, thank you.

You need to log in before you can comment on or make changes to this bug.