1607355 - Perma lint NameError: name 'basestring' is not defined

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Documentation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nerli [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=283716400&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/AvR0X09TRt-XVFO2UQfwCg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-01-06T22:04:52.441Z] File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 431, in call
[task 2020-01-06T22:04:52.441Z] module = self._original_import(name, globals, locals, fromlist, level)
[task 2020-01-06T22:04:52.441Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/config.py", line 13, in <module>
[task 2020-01-06T22:04:52.442Z] from .util.schema import validate_schema, Schema, optionally_keyed_by
[task 2020-01-06T22:04:52.442Z] File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 431, in call
[task 2020-01-06T22:04:52.442Z] module = self._original_import(name, globals, locals, fromlist, level)
[task 2020-01-06T22:04:52.442Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/schema.py", line 201, in <module>
[task 2020-01-06T22:04:52.442Z] {'index-search': [basestring]},
[task 2020-01-06T22:04:52.442Z] NameError: name 'basestring' is not defined
[task 2020-01-06T22:04:52.443Z]
[task 2020-01-06T22:04:52.443Z] WARNING: autodoc: failed to import module 'test_create' from module 'taskgraph.test'; the following exception was raised:
[task 2020-01-06T22:04:52.443Z] Traceback (most recent call last):
[task 2020-01-06T22:04:52.443Z] File "/builds/worker/checkouts/gecko/obj-x86_64-pc-linux-gnu/_virtualenvs/moztreedocs-A8BSWbM4/lib/python3.6/site-packages/sphinx/ext/autodoc/importer.py", line 32, in import_module
[task 2020-01-06T22:04:52.443Z] return importlib.import_module(modname)
[task 2020-01-06T22:04:52.444Z] File "/usr/lib/python3.6/importlib/init.py", line 126, in import_module
[task 2020-01-06T22:04:52.444Z] return _bootstrap._gcd_import(name[level:], package, level)
[task 2020-01-06T22:04:52.444Z] File "<frozen importlib._bootstrap>", line 994, in _gcd_import
[task 2020-01-06T22:04:52.444Z] File "<frozen importlib._bootstrap>", line 971, in _find_and_load
[task 2020-01-06T22:04:52.444Z] File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
[task 2020-01-06T22:04:52.448Z] File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
[task 2020-01-06T22:04:52.448Z] File "<frozen importlib._bootstrap_external>", line 678, in exec_module
[task 2020-01-06T22:04:52.448Z] File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
[task 2020-01-06T22:04:52.448Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/test/test_create.py", line 12, in <module>
[task 2020-01-06T22:04:52.449Z] from taskgraph.config import GraphConfig
[task 2020-01-06T22:04:52.449Z] File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 431, in call
[task 2020-01-06T22:04:52.449Z] module = self._original_import(name, globals, locals, fromlist, level)
[task 2020-01-06T22:04:52.449Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/config.py", line 13, in <module>
[task 2020-01-06T22:04:52.449Z] from .util.schema import validate_schema, Schema, optionally_keyed_by
[task 2020-01-06T22:04:52.449Z] File "/builds/worker/checkouts/gecko/build/mach_bootstrap.py", line 431, in call
[task 2020-01-06T22:04:52.449Z] module = self._original_import(name, globals, locals, fromlist, level)
[task 2020-01-06T22:04:52.449Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/schema.py", line 201, in <module>
[task 2020-01-06T22:04:52.449Z] {'index-search': [basestring]},
[task 2020-01-06T22:04:52.449Z] NameError: name 'basestring' is not defined

Comment 1

[Noemi Erli[:noemi_erli]]

Ethan, could this be a regression from https://bugzilla.mozilla.org/show_bug.cgi?id=1606026?

Comment 2

[Ethan Glasser-Camp (:glasserc)]

Oh no, that's something that I committed by accident, probably while doing a rebase. I'm sorry, please back it out.

Comment 3

[Ethan Glasser-Camp (:glasserc)]

Looking at it closer, I didn't commit the thing I was afraid I did and I have no idea what this means or why. It's certainly possible I caused it but I was having trouble with this file to begin with and tried not fiddling with it. Let me try on my machine.

Comment 4

[Ethan Glasser-Camp (:glasserc)]

Attachment: Bug 1607355: Fix path to redirect configuration

Comment 5

[Ethan Glasser-Camp (:glasserc)]

:Aryx and :malexandru spotted that I missed a spot in the redirects behavior. I think the error log above is just normal spew from the ./mach doc command and doesn't correspond to the actual failure.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a8dc8ffd737
Fix path to redirect configuration r=sylvestre

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1a8dc8ffd737

Comment 8

[Intermittent Failures Robot]

12 failures in 4472 pushes (0.003 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 12

Platform breakdown:

• lint: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1607355&startday=2020-01-06&endday=2020-01-12&tree=all