1607388 - [wpt-sync] Sync PR 21061 - Revert "Fix toJSON in WindowPerformance and PerformanceResourceTiming"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21061 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21061
Details from upstream follow.

Robert Liao <[e-mail]> wrote:

Revert "Fix toJSON in WindowPerformance and PerformanceResourceTiming"

This reverts commit 400050e6ae3d44a540786d89314419a0f8427d88.

Reason for revert: Failure on WebKit Linux MSAN
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20MSAN/3734

[3153/4358] external/wpt/uievents/idlharness.window.html failed unexpectedly (test timed out)

Original change's description:

Fix toJSON in WindowPerformance and PerformanceResourceTiming

Per https://heycam.github.io/webidl/#es-default-tojson, it is correct to
directly add the attribute values of the interface to the builder
instead of adding the results of toJSONForBinding().

Change-Id: I07f7ee5992de59938c0116f90dc4b5229c5d6e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982792
Reviewed-by: Jeremy Roman \<[e-mail]>
Commit-Queue: Nicolás Peña Moreno \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#728540}

TBR=[e-mail],[e-mail]

Change-Id: I06ebf62eb1217de6e7241b4c3ffa6a77d2c696da
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986572
Reviewed-by: Robert Liao \<[e-mail]>
Commit-Queue: Robert Liao \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#728775}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7086d3279f54d8de9944d221c8d6ad957b6ec92

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 42 tests

Status Summary

Firefox

OK : 3
PASS: 154[['GitHub']] 193[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']]

Chrome

OK : 3
PASS: 154

Safari

OK : 3
PASS: 120
FAIL: 34

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14ed07bb79f7
[wpt PR 21061] - Revert "Fix toJSON in WindowPerformance and PerformanceResourceTiming", a=testonly

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/14ed07bb79f7