1607429 - Remove unused functionality from ParseNode::getConstantValue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 1: Remove unused function BytecodeEmitter::emitSingletonInitialiser. r=mgaudet!

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 2: Remove no longer necessary AllowConstantObjects parameter. r=mgaudet!

The ForCopyOnWriteArray and DontAllowObjects flags are both unused, so we
can remove them along with the AllowConstantObjects parameter.

Also remove the NewObjectKind parameter because it's always TenuredObject.

Depends on D58927

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 3: Don't handle parse nodes not present in callsite objects. r=mgaudet!

getConstantValue() is only called for callsite objects, so we only need to handle
TemplateStringExpr, RawUndefinedExpr, CallSiteObj, and ArrayExpr (for the
raw nodes).

Depends on D58928

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 4: Only support callsite objects in getConstantValue. r=mgaudet!

Also remove the recursion for template-string and raw-undefined nodes.

With the recursion gone, it's easy to see the call to CombineArrayElementTypes
can be removed as well, because ncompare is always 0, which makes
CombineArrayElementTypes a no-op.

Finally we can then also remove the compare and ncompare parameters from
getConstantValue.

Depends on D58929

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 5: Remove explicit NewArrayKind parameter. r=mgaudet!

NewArrayKind::Normal is the default value when calling newArrayObject, so
there's no need to pass it explicitly.

Depends on D58930

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 6: Change getConstantValue to directly return an array object. r=mgaudet!

Depends on D58931

Comment 7

[André Bargull [:anba]]

Attachment: Bug 1607429 - Part 7: Move getConstantValue into CallSiteNode and rename it to getArrayValue. r=mgaudet!

Depends on D58932

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4ba2e73e400
Part 1: Remove unused function BytecodeEmitter::emitSingletonInitialiser. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/d61e2e6e9c07
Part 2: Remove no longer necessary AllowConstantObjects parameter. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/ebc34e43593e
Part 3: Don't handle parse nodes not present in callsite objects. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/7263c1322f9f
Part 4: Only support callsite objects in getConstantValue. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/a97c70e9b377
Part 5: Remove explicit NewArrayKind parameter. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/c09ecff23a9e
Part 6: Change getConstantValue to directly return an array object. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/118536529169
Part 7: Move getConstantValue into CallSiteNode and rename it to getArrayValue. r=mgaudet

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/e4ba2e73e400
https://hg.mozilla.org/mozilla-central/rev/d61e2e6e9c07
https://hg.mozilla.org/mozilla-central/rev/ebc34e43593e
https://hg.mozilla.org/mozilla-central/rev/7263c1322f9f
https://hg.mozilla.org/mozilla-central/rev/a97c70e9b377
https://hg.mozilla.org/mozilla-central/rev/c09ecff23a9e
https://hg.mozilla.org/mozilla-central/rev/118536529169