1607465 - Pinned tabs are jumping out of their normal position while being dragged

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: pinnedtabs.gif

Affected versions

• Firefox 72.0 (BuildId:20200103162918)
• Firefox 73.0b1 (BuildId:20200106175743)
• Firefox 74.0a1 (BuildId:20200107095722)

Affected platforms

• Windows 10 64bit.
• Windows 10 32bit.
• Windows 7 32bit.
• Ubuntu 18.04 64bit.
• macOS 10.11

Steps to reproduce

1. Launch Firefox.
2. Open around 20 tabs.
3. Pin several tabs.
4. Drag a pinned tab in order to change its position.

Expected result

• The pinned tab is successfully dragged and placed in a new position without any UI issues.

Actual result

• It seems that during the drag event the pinned tab shifts downwards (outside of its normal position), overlapping the beneath buttons.

Regression Range

• This seems to be a regression:
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0b0779e6ebe39537f30b6bed33a0201f0434d308&tochange=e7c2e224629a2245860707cc92080b204014f61b
• This issue seems to be caused by Bug 1576946 - Remove nsStackFrame platform code

Notes

• For further information regarding this issue please observe the attached screencast.
• It seems that this issue is only reproducible if multiple tabs are opened ( until the tab navigation buttons ( "<" and ">" are displayed).

Comment 1

[Tim Nguyen :ntim]

Emilio mentioned that bug 1606130 fixes this. :)

Comment 2

[Tim Nguyen :ntim]

Attachment: Bug 1607465 - Fix position of pinned tabs when dragged. r=bgrins

Comment 3

[Tim Nguyen :ntim]

[Tracking Requested - why for this release]: user visible regression when dragging tabs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1fc99ba989d
Fix position of pinned tabs when dragged. r=bgrins

Comment 5

[Tim Nguyen :ntim]

Comment on attachment 9119168 [details]
Bug 1607465 - Fix position of pinned tabs when dragged. r=bgrins

Beta/Release Uplift Approval Request

• User impact if declined: Wrong vertical alignment for pinned tabs when dragged
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): self-contained CSS change
• String changes made/needed: none

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/f1fc99ba989d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Not sure we need to track this for Fx72, but leaving this on the radar for a possible dot release ride-along given how trivial the patch is.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9119168 [details]
Bug 1607465 - Fix position of pinned tabs when dragged. r=bgrins

Trivial fix for a pretty obvious UI issue when dragging pinned tabs. Approved for 73.0b3.

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c2397fc9240

Comment 10

[Emil Ghitta, QA [:emilghitta]]

This issue is verified fixed using Firefox 74.0a1 (BuildId:20200108215606) and Firefox 73.0b3 (provided in comment 9) on Windows 10 64bit, macOS 10.13.6 and Ubuntu 18.04 64bit.

Leaving a ni on myself in case of a possible dot release.