1607488 - Perma browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - when Gecko version increases to 75 on 2020-02-10

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Stefan Hindli [:stefan_hindli]]

[Tracking Requested - why for this release]:

Central as Version Increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=91a10ab055d0141772ad67db49d218c853ab1a33&selectedJob=283830382

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283830382&repo=try

[task 2020-01-07T13:14:41.750Z] 13:14:41 INFO - TEST-START | browser/base/content/test/siteProtections/browser_protections_UI.js
[task 2020-01-07T13:14:42.500Z] 13:14:42 INFO - TEST-INFO | started process screentopng
[task 2020-01-07T13:14:42.953Z] 13:14:42 INFO - TEST-INFO | screentopng: exit 0
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages logged at 13:14:41
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Entering test bound setup
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Leaving test bound setup
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Entering test bound testToggleSwitch
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages logged at 13:14:42
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html" line: 0}]
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages finished
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54 - TypeError: events is undefined
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Stack trace:
[task 2020-01-07T13:14:42.955Z] 13:14:42 INFO - testToggleSwitch@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54:22
[task 2020-01-07T13:14:42.955Z] 13:14:42 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:42.956Z] 13:14:42 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:42.956Z] 13:14:42 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:42.957Z] 13:14:42 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:42.957Z] 13:14:42 INFO - Leaving test bound testToggleSwitch
[task 2020-01-07T13:14:42.958Z] 13:14:42 INFO - Entering test bound testSettingsButton
[task 2020-01-07T13:14:43.616Z] 13:14:43 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | about:preferences has been opened successfully -
[task 2020-01-07T13:14:43.616Z] 13:14:43 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82 - TypeError: events is undefined
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - Stack trace:
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - checkClickTelemetry@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82:22
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - testSettingsButton@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:247:22
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - Leaving test bound testSettingsButton
[task 2020-01-07T13:14:43.620Z] 13:14:43 INFO - Entering test bound testShowFullReportButton
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | about:protections has been opened successfully -
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82 - TypeError: events is undefined
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - Stack trace:
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - checkClickTelemetry@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82:22
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - testShowFullReportButton@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:282:22
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:44.588Z] 13:14:44 INFO - Leaving test bound testShowFullReportButton
[task 2020-01-07T13:14:44.589Z] 13:14:44 INFO - Entering test bound testMiniPanel
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The panel header is displayed as the content of the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-tp-switch-section' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'tracking-protection-container' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-footer' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-milestones' is hidden in the toast. -

Comment 1

[Intermittent Failures Robot]

21 failures in 795 pushes (0.026 failures/push) were associated with this bug yesterday.

Repository breakdown:

• try: 21

Platform breakdown:

• linux64: 8
• macosx1014-64: 1
• windows7-32: 2
• windows10-64-qr: 2
• windows10-64: 3
• linux64-shippable: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1607488&startday=2020-01-07&endday=2020-01-07&tree=all

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 74 as we should fix this before 74 goes to beta (Feb 10)

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Erica, can you help find an owner for this issue? Thanks!

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Erica, I think this regressed after the appmenu protections button telemetry patch you landed? I can't get to this before next week, let me know if you'd like me to take it next week, please.

Comment 6

[Erica Wright [:ewright]]

(In reply to Nihanth Subramanya [:nhnt11] from comment #5)

Erica, I think this regressed after the appmenu protections button telemetry patch you landed? I can't get to this before next week, let me know if you'd like me to take it next week, please.

I'm not sure about that, since the telemetry only just landed at the same time as your comment, this is from the last few days. I'll look into it though, assigning myself.

Comment 7

[Intermittent Failures Robot]

21 failures in 4472 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 21

Platform breakdown:

• linux64: 8
• macosx1014-64: 1
• windows7-32: 2
• windows10-64-qr: 2
• windows10-64: 3
• linux64-shippable: 1
• macosx1014-64-shippable: 1
• windows7-32-shippable: 1
• windows10-64-shippable: 1
• windows10-64-shippable-qr: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1607488&startday=2020-01-06&endday=2020-01-12&tree=all

Comment 8

[Erica Wright [:ewright]]

I believe this is because the data expires in 75. We need to decide whether to renew.
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#1544,1609

We should submit the data extension request if so.

Comment 9

[Pascal Chevrel:pascalc]

Cindy, Erica, with the all hands in Berlin next week and the merge just after, this bug needs rapid action if it needs a data review. Can we get a status update on this one please? Thanks

Comment 10

[Erica Wright [:ewright]]

thank you, I'll put up a data review request now

Comment 11

[Erica Wright [:ewright]]

Attachment: Bug 1607488 - Update telemetry for protections panel.

Comment 12

[Erica Wright [:ewright]]

Attachment: request.md

Please renew all data for the protection panel collection, until 80.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:ewright, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f181aaf73691
Update telemetry for protections panel. r=nhnt11

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f181aaf73691

Comment 16

[Cosmin Sabou [:CosminS]]

Fix verified in today's version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=9601c58e8991f23fc2a442a37819feae731864f3&searchStr=%28bc&selectedJob=287737377