Closed Bug 1607488 Opened 4 years ago Closed 4 years ago

Perma browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - when Gecko version increases to 75 on 2020-02-10

Categories

(Firefox :: Protections UI, defect, P1)

Product:
Firefox
Component:
Protections UI
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 74
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- unaffected
firefox73 --- unaffected
firefox74 + verified

People

(Reporter: stefan_hindli, Assigned: ewright)

References

Details

(Keywords: regression)

Attachments

(2 files)

Bug 1607488 - Update telemetry for protections panel.
47 bytes, text/x-phabricator-request
Details | Review
request.md
737 bytes, text/plain
teon
: data-review+
Details

[Tracking Requested - why for this release]:

Central as Version Increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=91a10ab055d0141772ad67db49d218c853ab1a33&selectedJob=283830382

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=283830382&repo=try

[task 2020-01-07T13:14:41.750Z] 13:14:41 INFO - TEST-START | browser/base/content/test/siteProtections/browser_protections_UI.js
[task 2020-01-07T13:14:42.500Z] 13:14:42 INFO - TEST-INFO | started process screentopng
[task 2020-01-07T13:14:42.953Z] 13:14:42 INFO - TEST-INFO | screentopng: exit 0
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages logged at 13:14:41
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Entering test bound setup
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Leaving test bound setup
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Entering test bound testToggleSwitch
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages logged at 13:14:42
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Console message: [JavaScript Warning: "The resource at “http://trackertest.org/” was blocked because content blocking is enabled." {file: "http://tracking.example.org/browser/browser/base/content/test/trackingUI/trackingPage.html" line: 0}]
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Buffered messages finished
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54 - TypeError: events is undefined
[task 2020-01-07T13:14:42.954Z] 13:14:42 INFO - Stack trace:
[task 2020-01-07T13:14:42.955Z] 13:14:42 INFO - testToggleSwitch@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54:22
[task 2020-01-07T13:14:42.955Z] 13:14:42 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:42.956Z] 13:14:42 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:42.956Z] 13:14:42 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:42.957Z] 13:14:42 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:42.957Z] 13:14:42 INFO - Leaving test bound testToggleSwitch
[task 2020-01-07T13:14:42.958Z] 13:14:42 INFO - Entering test bound testSettingsButton
[task 2020-01-07T13:14:43.616Z] 13:14:43 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | about:preferences has been opened successfully -
[task 2020-01-07T13:14:43.616Z] 13:14:43 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82 - TypeError: events is undefined
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - Stack trace:
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - checkClickTelemetry@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82:22
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - testSettingsButton@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:247:22
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:43.617Z] 13:14:43 INFO - Leaving test bound testSettingsButton
[task 2020-01-07T13:14:43.620Z] 13:14:43 INFO - Entering test bound testShowFullReportButton
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | about:protections has been opened successfully -
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82 - TypeError: events is undefined
[task 2020-01-07T13:14:44.586Z] 13:14:44 INFO - Stack trace:
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - checkClickTelemetry@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/head.js:82:22
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - testShowFullReportButton@chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:282:22
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - AsyncTester_execTest/<@chrome://mochikit/content/browser-test.js:1062:34
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - asyncTester_execTest@chrome://mochikit/content/browser-test.js:1097:11
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:925:14
[task 2020-01-07T13:14:44.587Z] 13:14:44 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:808:67
[task 2020-01-07T13:14:44.588Z] 13:14:44 INFO - Leaving test bound testShowFullReportButton
[task 2020-01-07T13:14:44.589Z] 13:14:44 INFO - Entering test bound testMiniPanel
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The panel header is displayed as the content of the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-tp-switch-section' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'tracking-protection-container' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-footer' is hidden in the toast. -
[task 2020-01-07T13:14:45.001Z] 13:14:45 INFO - TEST-PASS | browser/base/content/test/siteProtections/browser_protections_UI.js | The section 'protections-popup-milestones' is hidden in the toast. -

Flags: needinfo?(nhnt11)
Summary: TEST-UNEXPECTED-FAIL | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54 - TypeError: events is undefine → Perma | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54 - TypeError: events is undefine
Component: General → Protections UI

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Keywords: regression

Tracking for 74 as we should fix this before 74 goes to beta (Feb 10)

Erica, can you help find an owner for this issue? Thanks!

tracking-firefox74: ? → +
Flags: needinfo?(ewright)

Erica, I think this regressed after the appmenu protections button telemetry patch you landed? I can't get to this before next week, let me know if you'd like me to take it next week, please.

Flags: needinfo?(nhnt11)
Summary: Perma | browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/siteProtections/browser_protections_UI.js:54 - TypeError: events is undefine → Perma browser/base/content/test/siteProtections/browser_protections_UI.js | Uncaught exception - when Gecko version increases to 75 on 2020-02-10

(In reply to Nihanth Subramanya [:nhnt11] from comment #5)

Erica, I think this regressed after the appmenu protections button telemetry patch you landed? I can't get to this before next week, let me know if you'd like me to take it next week, please.

I'm not sure about that, since the telemetry only just landed at the same time as your comment, this is from the last few days. I'll look into it though, assigning myself.

Flags: needinfo?(ewright)
Assignee: nobody → ewright
Status: NEW → ASSIGNED

I believe this is because the data expires in 75. We need to decide whether to renew.
https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#1544,1609

We should submit the data extension request if so.

Flags: needinfo?(chsiang)

Cindy, Erica, with the all hands in Berlin next week and the merge just after, this bug needs rapid action if it needs a data review. Can we get a status update on this one please? Thanks

Flags: needinfo?(ewright)

thank you, I'll put up a data review request now

Flags: needinfo?(ewright)
Attached file request.md —

Please renew all data for the protection panel collection, until 80.

Attachment #9122410 - Flags: data-review?(teon)
Flags: needinfo?(chsiang)

The priority flag is not set for this bug.
:ewright, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ewright)
Flags: needinfo?(ewright)
Priority: -- → P1
Attachment #9122410 - Flags: data-review?(teon) → data-review+
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f181aaf73691
Update telemetry for protections panel. r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/f181aaf73691

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox74: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: