Closed Bug 1607544 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 21076 - Reland "Fix toJSON in WindowPerformance and PerformanceResourceTiming"

Categories

(Core :: Performance, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox74 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 21076 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21076
Details from upstream follow.

Nicolás Peña Moreno <npm@chromium.org> wrote:

Reland "Fix toJSON in WindowPerformance and PerformanceResourceTiming"

This is a reland of 400050e6ae3d44a540786d89314419a0f8427d88

Original change's description:

Fix toJSON in WindowPerformance and PerformanceResourceTiming

Per https://heycam.github.io/webidl/#es-default-tojson, it is correct to
directly add the attribute values of the interface to the builder
instead of adding the results of toJSONForBinding().

Change-Id: I07f7ee5992de59938c0116f90dc4b5229c5d6e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982792
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#728540}

Change-Id: I17040d340904260b1594c11dbfd4253c05412450

Reviewed-on: https://chromium-review.googlesource.com/1989577
WPT-Export-Revision: 9e106fccfe4ccb335a20727b229161a503ce095c

Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 75 subtests

Status Summary

Firefox

OK : 3
PASS: 296

Chrome

OK : 3
PASS: 293
FAIL: 3

Safari

OK : 3
PASS: 243
FAIL: 53

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b48868390be8
[wpt PR 21076] - Reland "Fix toJSON in WindowPerformance and PerformanceResourceTiming", a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.