Data Collection Review Request: application-services Places Manager quality metrics
Categories
(Firefox :: Sync, task)
Tracking
()
People
(Reporter: lougenia, Unassigned)
References
Details
Attachments
(1 file)
4.44 KB,
text/plain
|
chutten
:
data-review+
|
Details |
+++ This bug was initially created as a clone of Bug #1597895 +++
The application-services Places Manager is a re-usable component for storing and syncing saved bookmarks and browser history, currently used in the Fenix and Firefox Reality:
https://github.com/mozilla/application-services/tree/master/components/places
Since this is a new component underlying an important piece of browser functionality, we'd like to gather some basic quality and performance metrics so we can be confident it is working correctly. A skeleton of the metrics-gathering code (including the proposed Glean metrics.yaml file) is being developed here:
https://github.com/mozilla/application-services/pull/2431
This bug is to track review of the proposed telemetry collection, and I'll attach the review request template presently...
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Lougenia, I noticed that you set data-review+ instead of requesting a data-review to a Data Steward as outlined here. Was this intentional?
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 2•5 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #1)
Lougenia, I noticed that you set data-review+ instead of requesting a data-review to a Data Steward as outlined here. Was this intentional?
Alessio, sadly that was not intentional. Ticket has been updated--my apologies.
Reporter | ||
Updated•5 years ago
|
Comment 3•5 years ago
|
||
Reporter | ||
Comment 4•5 years ago
|
||
(In reply to Chris H-C :chutten from comment #3)
Comment on attachment 9119272 [details]
data-review-request.mdWill places use glean_parser's automatic documentation output to generate
human-readable documentation for the data collections?(( public-facing documentation is one of the criteria I
need to
proceed with data collection review ))
Yes, we'll be using glean_parser to generate the places metrics documentation. We're actually considering adding the parser to our CI build process so that changes to the metrics.yaml
file are automatically generated. Is that a sufficient answer or is more required to satisfy that condition?
Comment 5•5 years ago
|
||
(In reply to Lougenia Bailey from comment #4)
(In reply to Chris H-C :chutten from comment #3)
Comment on attachment 9119272 [details]
data-review-request.mdWill places use glean_parser's automatic documentation output to generate
human-readable documentation for the data collections?(( public-facing documentation is one of the criteria I
need to
proceed with data collection review ))Yes, we'll be using glean_parser to generate the places metrics documentation. We're actually considering adding the parser to our CI build process so that changes to the
metrics.yaml
file are automatically generated. Is that a sufficient answer or is more required to satisfy that condition?
Hey Lougenia, sorry if I chime in here :-) I think you're already integrating it (otherwise you wouldn't be able to use the Glean SDK!). The docs are available in your PR here.
Reporter | ||
Comment 6•5 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #5)
(In reply to Lougenia Bailey from comment #4)
(In reply to Chris H-C :chutten from comment #3)
Comment on attachment 9119272 [details]
data-review-request.mdWill places use glean_parser's automatic documentation output to generate
human-readable documentation for the data collections?(( public-facing documentation is one of the criteria I
need to
proceed with data collection review ))Yes, we'll be using glean_parser to generate the places metrics documentation. We're actually considering adding the parser to our CI build process so that changes to the
metrics.yaml
file are automatically generated. Is that a sufficient answer or is more required to satisfy that condition?Hey Lougenia, sorry if I chime in here :-) I think you're already integrating it (otherwise you wouldn't be able to use the Glean SDK!). The docs are available in your PR here.
I was answered assuming the existence of the generated docs was known but by making that assumption and answering the way I did I may have confused the matter. Long story short, I appreciate the clarification.
Comment 7•5 years ago
|
||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
This has data-review+ and the corresponding changes have landed in github, so I'm going to close out the bug. Thanks all!
Description
•