Open Bug 1607636 Opened 6 years ago Updated 5 days ago

Intermittent devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js | single tracking bug

Categories

(DevTools :: Debugger, defect, P5)

defect

Tracking

(Not tracked)

REOPENED

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Blocks 1 open bug, Regressed 1 open bug, Regression)

Details

(Keywords: intermittent-failure, leave-open, regression, Whiteboard: [retriggered] [stockwell disabled])

Attachments

(7 files)

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=283923454&repo=mozilla-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/aIE7xYUNSBiiM50AfAhflQ/runs/0/artifacts/public/logs/live_backing.log


[task 2020-01-08T00:07:12.735Z] 00:07:12 INFO - Invoking in tab: btnClick()
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js | The correct node was highlighted -
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Buffered messages logged at 00:06:31
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Resuming from 30
[task 2020-01-08T00:07:12.736Z] 00:07:12 INFO - Waiting for state change: paused
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Buffered messages logged at 00:06:40
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Finished waiting for state change: paused
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Finished waiting for state change: paused
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Waiting for state change: fetched frames
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Finished waiting for state change: fetched frames
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Waiting for state change: selected source
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Finished waiting for state change: selected source
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - Buffered messages finished
[task 2020-01-08T00:07:12.737Z] 00:07:12 INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js | Test timed out -
[task 2020-01-08T00:07:14.818Z] 00:07:14 INFO - Removing tab.
[task 2020-01-08T00:07:14.818Z] 00:07:14 INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-01-08T00:07:14.833Z] 00:07:14 INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-01-08T00:07:14.848Z] 00:07:14 INFO - Tab removed and finished closing

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Regressed by: 1623667
Whiteboard: [retriggered]
Has Regression Range: --- → yes
Keywords: regression
Assignee: nobody → ccoroiu
Pushed by smolnar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c974825ebcb3 disable browser_dbg-inline-preview.js for frequent failures r=intermittent-reviewers,jmaher DONTBUILD
Keywords: leave-open
Whiteboard: [retriggered][stockwell disable-recommended] → [retriggered] [stockwell disabled]

Did not investigate. Removing myself.

Flags: needinfo?(rcaliman)

The bug assignee didn't login in Bugzilla in the last 7 months.
:bomsy, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: ccoroiu → nobody
Flags: needinfo?(hmanilla)
Severity: normal → S3
Flags: needinfo?(hmanilla)

Looks like these can be enabled, tests are looking good ...

Pushed by hmanilla@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/20f47ccae0cf [devtools] Enable the inline preview test r=devtools-reviewers,ochameau
Regressions: 1945327

The test hangs when testing the inline preview of a node. But the current logs make it difficult to know exactly where we hang.

After adding more logs we time out waiting for inlinePreviewOpenInspector to be displayed https://searchfox.org/mozilla-central/rev/08b2a1a770688df19a5a43fd89fb63b34bb2d6a6/devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js#136

So it's possible that the preview is simply never displayed.

Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a66fd104666f [devtools] Improve logs for debugger mochitest helpers r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/4dd189b097fd [devtools] Remove duplicated waitUntil helper in client/shared/test/head.js r=devtools-reviewers,nchevobbe https://hg.mozilla.org/integration/autoland/rev/4629bac77312 [devtools] Skip browser_dbg-inline-preview.js on linux TSAN r=devtools-reviewers,nchevobbe

Strong spike of failures since June 18th, anything changed on the inline preview side?

Whiteboard: [retriggered] [stockwell disabled] → [devtools-triage][retriggered] [stockwell disabled]

(In reply to Julian Descottes [:jdescottes] from comment #54)

Strong spike of failures since June 18th, anything changed on the inline preview side?

Bug 1957885 landed recently, so it could be the culprit? i'll take a look.

The test always hangs at https://searchfox.org/mozilla-central/rev/ec8a326713f60dec138a3e3383b03ac739870fc7/devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js#128-132

await assertInlinePreviews(
  dbg,
  [{ previews: [{ identifier: "btn:", value: "button" }], line: 53 }],
  "onBtnClick"
);
Attached image image.png

Failure screenshot. In theory we expect to have an inline preview for the btn button element here.

Let's try to select the source first and then trigger the breakpoint.

Flags: needinfo?(jdescottes)
Whiteboard: [devtools-triage][retriggered] [stockwell disabled] → [retriggered] [stockwell disabled]

Interestingly this fails very often on try! Clicking on the inspector button always seems to fail on linux opt

Yes, no idea why this happens, but adding a 1second delay before clicking the inspector icon finally seems to fix the intermittent.
I don't know if it's a different race condition than the one related to selecting the source, but they must be related somehow: https://treeherder.mozilla.org/jobs?repo=try&revision=cc1bf07f66c86201039ec96df2c368ecb48a13d1

Pushed by jdescottes@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8c1ac4801f69 https://hg.mozilla.org/integration/autoland/rev/9bfce4284d43 [devtools] Select the source and poll for highlight in browser_dbg-inline-preview.js r=bomsy,devtools-reviewers,nchevobbe
Regressions: 1974696
Summary: Intermittent devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js | Test timed out - → Intermittent devtools/client/debugger/test/mochitest/browser_dbg-inline-preview.js | single tracking bug
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: