1607652 - Firefox won't delete key3.db if the profile path contains non-ASCII string on Windows

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Masatoshi Kimura [:emk]]

GetNSSProfilePath will make a UTF-8 file path on Windows:
https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/security/manager/ssl/nsNSSComponent.cpp#1413-1425

But MaybeCleanUpOldNSSFiles > GetFileIfExists passes the string to InitWithNativePath that expects ANSI encoded file paths:
https://searchfox.org/mozilla-central/rev/a92ed79b0bc746159fc31af1586adbfa9e45e264/security/manager/ssl/nsNSSComponent.cpp#1545

GetFileIfExists should convert the profile path to UTF-16 and use InitWithPath.

Comment 1

[Kai Engert [:KaiE:]]

See also bug 1607542. Not sure if mozilla-central still needs this fix.

Should this be fixed on esr68 ?

Comment 2

[Kai Engert [:KaiE:]]

(In reply to Masatoshi Kimura [:emk] from comment #0)

GetFileIfExists should convert the profile path to UTF-16

How?

Comment 3

[Masatoshi Kimura [:emk]]

Something like:

#ifdef XP_WIN
  // |path| is encoded in UTF-8 because SQLite always takes UTF-8 file paths
  // regardless of the current system code page.
  nsresult rv = file->InitWithPath(NS_ConvertUTF8toUTF16(path));
#else
  nsresult rv = file->InitWithNativePath(path);
#endif

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Bug 1607652 - Handle non-ASCII profile path correctly when dealing with key3.db and pkcs11.txt on Windows. r?keeler

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8b5627432c6
Handle non-ASCII profile path correctly when dealing with key3.db and pkcs11.txt on Windows. r=keeler

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f8b5627432c6