1607692 - QM: Investigate why the storage connection is sometimes not closed in QuotaManager::~QuotaManager

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

We found this issue in bug 1604005 and we need to do more investigation.

Comment 1

[Jan Varga [:janv]]

In general, QuotaManager::ShutdownStorage triggers flushing of not yet committed data to disk and closing of files correctly, so it is quite important that it runs before QuotaManager object is destroyed.

Comment 2

[Jan Varga [:janv]]

I think I know why this can happen, I'll describe it in next comment.

Comment 3

[Jan Varga [:janv]]

I think the real problem is that we don't wait for StorageOperationBase objects to finish in QuotaManager::Shutdown before we schedule a runnable to QM I/O thread for calling QuotaManager::ShutdownStorage which closes the storage connection.

We need to add tracking of these objects, so we spin the event loop in QuotaManager::Shutdown until these objects are finished.

I'll try to create a patch for this.

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1607692 - Change return type of QuotaUsageRequestBase::Init and QuotaRequestBase::Init from bool to void; r=dom-workers-and-storage-reviewers

These methods never return false, so they can be safely converted to return void.

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1607692 - Wait for all normal origin operations to finish before shutting down QuotaManager; r=dom-workers-and-storage-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/177f23c6bc89
Change return type of QuotaUsageRequestBase::Init and QuotaRequestBase::Init from bool to void; r=dom-workers-and-storage-reviewers,ttung
https://hg.mozilla.org/integration/autoland/rev/9793a4979340
Wait for all normal origin operations to finish before shutting down QuotaManager; r=dom-workers-and-storage-reviewers,ttung

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/177f23c6bc89
https://hg.mozilla.org/mozilla-central/rev/9793a4979340