[mozcrash] drop generic rust boilerplate stacks from drop of crash reports to get meaningful signatures
Categories
(Testing :: Mozbase, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: aryx, Unassigned)
References
(Depends on 1 open bug)
Details
See e.g. bug 1607553 which has [@ RustMozCrash(char const*, int, char const*)]
as crash signature. The meaningful crash signature [@ style::rule_tree::{{impl}}::drop(struct style::rule_tree::StrongRuleNode )]
got used months earlier, see bug 1562706.
Dropping/ignoring crash frames from the top up to panicking::begin_panic
allows better grouping and tracking of these issues.
There might already be a bug for this.
Reporter | ||
Comment 2•4 years ago
|
||
Toolkit::Crash Reporting instead? Crashes from CI aren't reported to Socorro (or is a Socorro library involved?).
Comment 3•4 years ago
|
||
I don't know. At least we do not have any specific rules set within mozcrash. Maybe Gabriele can help here.
Comment 4•4 years ago
|
||
If crash reports from CI don't go through Socorro, where'd the signature come from?
Comment 5•4 years ago
|
||
It's not a signature, it's just the function name of the first frame in the stack after skipping a certain set of functions, see this and this
RustMozCrash
is part of the list of skipped functions but apparently the code isn't filtering it out correctly. So maybe this is a bug in mozcrash?
On the topic, Will made a Socorro's signature-generation functionality available as a stand-alone python module. It would be nice to integrate it in mozcrash so as to have the same signatures across both systems.
Comment 6•4 years ago
|
||
Sorry, looks I was wrong. So moving back to mozbase.
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Kris Wright has been doing some work around how mozcrash processes crashes so I've pinged her in bug 867571 and made it a dependency here. If that gets fixed this should be fixed too.
Updated•2 years ago
|
Description
•