disablePictureInPicture attribute does not work
Categories
(Core :: Audio/Video: Playback, defect)
Tracking
()
People
(Reporter: naktinis, Unassigned)
Details
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
Create a video element with a "disablePictureInPicture" attribute (as per spec https://w3c.github.io/picture-in-picture/#disable-pip).
Actual results:
The blue hovering PiP button appeared anyway, and the PiP option was present in the context menu.
Expected results:
According to the spec:
"If the disablePictureInPicture attribute is present on the video element, the user agent SHOULD NOT play the video element in Picture-in-Picture or present any UI to do so."
Works correctly on Chrome (the context menu option gets disabled).
If someone can provide hints about the relevant source files, I might be able to contribute a patch.
|
||
Comment 1•5 years ago
|
||
Hey Mike,
I believe you could pinpoint naktinis to the right direction regarding the PiP attribute. Please take a look at this when you have the time. Thanks!
|
||
Comment 2•5 years ago
|
||
disablePictureInPicture is part of the w3c's PictureInPicture WebAPI spec, which is not something that Mozilla currently implements.
See https://github.com/mozilla/standards-positions/issues/72 and https://hacks.mozilla.org/2020/01/how-we-built-picture-in-picture-in-firefox-desktop/
|
|
||
Comment 3•5 years ago
|
||
Marking this as INVALID for now, since our built-in Picture-in-Picture implementation is ignoring the WebAPI as intended.
Hello everyone,
I just need to jump in here and ask for more details, because the resolving of the bug ticket is invalid, not the requested bugfix.
For sure, user will be happy if they have always the same user experience, but I'm as a developer can't accept the statement: "The bug ticket is invalid, because we IGNORE intentionally a given web standard". When I read your linked article I was near flipping my table, because I couldn't believe, that you actually really ignore this.
I as a developer, which works for a video company, need to be able to disable this feature. Using this feature breaks given restrictions how users are allowed to consume our content for free. If you now allow them to rescale the window and ignore player overlays, this feature becomes a nightmare for us. How can you just implement a feature, that kind of grabs content without any way to prevent the browser from doing this, if you as a video provider don't want this to happen?
Thank you in advance for any information about how a website provider can take part in this behavior.
Regards
|
|
||
Comment 5•5 years ago
|
||
Additional conversation around this has taken place in bug 1611831, so duping to that bug.
Description
•