Intermittent toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_telemetry.js | test_blocklist_useXML_scalar - [test_blocklist_useXML_scalar : 25] when the Firefox version increases to 75 on 2020-02-10
Categories
(Toolkit :: Add-ons Manager, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox72 | --- | unaffected |
firefox73 | --- | unaffected |
firefox74 | + | verified |
People
(Reporter: intermittent-bug-filer, Assigned: rpl)
References
Details
(Keywords: intermittent-failure)
Attachments
(2 files)
1.41 KB,
text/plain
|
nshadowen
:
data-review+
|
Details |
47 bytes,
text/x-phabricator-request
|
Details | Review |
Filed by: archaeopteryx [at] coole-files.de
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=283834554&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/PK_KUCzZQq6jG8tKNcu7Nw/runs/0/artifacts/public/logs/live_backing.log
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - "CONSOLE_MESSAGE: (info) 1578406612779 addons.manager DEBUG Completed startup sequence"
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - (xpcshell/head.js) | test run_next_test 1 pending (2)
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - (xpcshell/head.js) | test test_setup finished (2)
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_telemetry.js | Starting test_blocklist_useXML_scalar
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - (xpcshell/head.js) | test test_blocklist_useXML_scalar pending (2)
[task 2020-01-07T14:16:53.135Z] 14:16:53 WARNING - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_telemetry.js | test_blocklist_useXML_scalar - [test_blocklist_useXML_scalar : 25] Got the expected value for blocklist.useXML scalar - "undefined" == false
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:/task_1578403901/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_telemetry.js:assertTelemetryScalars:25
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:/task_1578403901/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_telemetry.js:test_blocklist_useXML_scalar:46
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:\task_1578403901\build\tests\xpcshell\head.js:run_next_test/_run_next_test/<:1567
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:\task_1578403901\build\tests\xpcshell\head.js:_run_next_test:1567
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:\task_1578403901\build\tests\xpcshell\head.js:run:735
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:\task_1578403901\build\tests\xpcshell\head.js:_do_main:246
[task 2020-01-07T14:16:53.135Z] 14:16:53 INFO - Z:\task_1578403901\build\tests\xpcshell\head.js:_execute_test:573
Please check all the probes added by bug 1572711.
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Hi Gijs,
The telemetry probes we added in Bug 1572711 are currently set to expire in Firefox 75 (and so the tests fail on the beta simulation),
before I proceed to renew them I wanted to double-check with you first (if and for how many additional releases we do want to keep the probes related to the XML-based implementation).
e.g. do we want to renew all of them as they are for 2-3 more releases? what do you think?
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
(In reply to Luca Greco [:rpl] [:luca] [:lgreco] from comment #1)
Hi Gijs,
The telemetry probes we added in Bug 1572711 are currently set to expire in Firefox 75 (and so the tests fail on the beta simulation),
before I proceed to renew them I wanted to double-check with you first (if and for how many additional releases we do want to keep the probes related to the XML-based implementation).
e.g. do we want to renew all of them as they are for 2-3 more releases? what do you think?
I think we should renew the XML ones for 2 more releases and the remote settings one for the habitual 6 months (which will be 6 or 7 releases). We'll want to monitor uptake and be able to compare the two probes, and we're only switching for the 72 release after the release, so having the XML probes gone on nightly at that point will be problematic if we have to stop the rollout or there are any other issues.
Comment 3•5 years ago
|
||
Note that you'll need data review but there's a much shorter list of questions - see https://github.com/mozilla/data-review/blob/master/renewal_request.md .
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to :Gijs (he/him) from comment #2)
I think we should renew the XML ones for 2 more releases and the remote settings one for the habitual 6 months (which will be 6 or 7 releases). We'll want to monitor uptake and be able to compare the two probes, and we're only switching for the 72 release after the release, so having the XML probes gone on nightly at that point will be problematic if we have to stop the rollout or there are any other issues.
Thanks, that was what I was thinking of too (as I was pretty sure we still wanted the XML one for a bit more during the roll out, but likely for a smaller amount of releases than the RS one).
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Changing the priority to p2 as the bug is tracked by a release manager for the current nightly.
See What Do You Triage for more information
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Hi Nicole,
this issue is being tracked for Firefox 74 (because the expiring telemetry probes are going to trigger some test failures once we increase the version in mozilla-central) and so I was wondering if it would be possible for you to review this data request before the end of the week
(the data review form is the shorter one used for the renewals).
I'd like to land the patch (which is already signed off by a telemetry peer) before we are all going to travel to the All Hands next week.
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
bugherder |
Comment 14•5 years ago
|
||
Fix verified in today's version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedJob=287745908&resultStatus=success%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=9601c58e8991f23fc2a442a37819feae731864f3&searchStr=xpc
Description
•