1607778 - Debugging support for Shared Workers

Status: NEW

(DevTools :: Debugger, enhancement, P5)

Description

[:Harald Kirschner :digitarald]

Test page: http://mdn.github.io/simple-shared-worker/

Comment 1

[Brian Hackett [Laid off!]]

Attachment: patch

This patch shows shared workers in the debugger's threads pane, if the new devtools.debugger.features.windowless-shared-workers preference is set.

This is pretty straightforward, but there is a question here of which shared workers should be shown in the debugger. Unlike service workers, tabs have to explicitly connect with a shared worker by creating it, but information about these connections isn't exposed in IDLs as far as I can see. This patch avoids this issue by showing all shared workers that are same-origin with the tab being debugged, similar to what we do with service workers. This should give a pretty good result while avoiding difficulties managing the state around which tabs are connected to which shared workers.

Comment 2

[Brian Hackett [Laid off!]]

Attachment: Bug 1607778 Part 1 - Add nsIWorkerDebugger.resolvedURI, r=asuth.

Comment 3

[Brian Hackett [Laid off!]]

Attachment: Bug 1607778 Part 2 - Don't run port identifier runnable until after the debugger has attached, r=asuth.

Depends on D59640

Comment 4

[Brian Hackett [Laid off!]]

Attachment: Bug 1607778 Part 3 - Attach to shared workers in the debugger, r=jdescottes.

Depends on D59641

Comment 5

[:Harald Kirschner :digitarald]

Honza: Not sure how bad bitrot will be here and how much work is still needed. Could you assess if we should park it for later or give it the nudge it needs now?

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Baku, would you know if we can/how hard it would be to expose the windows a given SharedWorker lives in, in the WorkerDebugger ?
The idea would be able to properly display the shared worker in the debugger and in the console evaluation context selector, in the content toolbox.

Comment 7

[Andrea Marchesini [:baku]]

We could expose the list of window IDs. Is it enough?

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

yeah, I think that it would be great

Comment 9

[Andrea Marchesini [:baku]]

Asuth, is it something you (or the worker/storage team) have time to work on?

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

Yes, I file bug 1657130 to cover implementing this and will share it at our team meeting today.

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nicolas, Andrew, thanks for helping with this one!