Closed Bug 1607783 Opened 4 years ago Closed 4 years ago

Check precondition `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`

Categories

(Core :: DOM: Selection, enhancement)

Product:
Core
Component:
DOM: Selection
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla74
Tracking Flags:
Tracking Status
firefox74 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1607783: check precondition in `nsRange::IsNodeSelected`. r=smaug
47 bytes, text/x-phabricator-request
Details | Review

Otherwise it's hard to reason about the method and its implementation, moreover it could return wrong results.

Summary: Assert `aStartOffset <= aEndOffset` for `nsRange::IsNodeSelected` → Assert `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
Summary: Assert `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected` → Check invariant `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
Summary: Check invariant `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected` → Check precondition `aStartOffset <= aEndOffset` in `nsRange::IsNodeSelected`
Attachment #9119667 - Attachment description: Bug 1607783: check invariant in `nsRange::IsNodeSelected`. r=smaug → Bug 1607783: check precondition in `nsRange::IsNodeSelected`. r=smaug
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/221163f3f179
check precondition in `nsRange::IsNodeSelected`. r=smaug

https://hg.mozilla.org/mozilla-central/rev/221163f3f179

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox74: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: