1607794 - [wpt-sync] Sync PR 21087 - css-deprecated-flexbox: fixes coordinates when flipped

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21087 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21087
Details from upstream follow.

Scott Violet <[e-mail]> wrote:

css-deprecated-flexbox: fixes coordinates when flipped

-webkit-box always starts horizontal layout from an x position of
0. rtl is handled by starting at 0 and iterating in reverse.
https://chromium-review.googlesource.com/c/chromium/src/+/1876073
got close to this by making the width_for_rtl come from the
hypothetical size. Unfortunately that doesn't deal with flex.
This patch changes how coordiantes are calculated when flipped to
better give behavior expected of -webkit-box, and it also changes when
start/end are flipped.

I've add more test cases with a bunch of variations to ensure all cases
are handled.

This also changes the expectations of
paint/invalidation/overflow/float-overflow-right.html. The expectations
now match that before the patch at
https://chromium-review.googlesource.com/c/chromium/src/+/1876073

BUG=1034461 1037764
TEST=external/wpt/compat/webkit-box-rtl-flex.html
external/wpt/compat/webkit-box-horizontal-rtl-variants.html
external/wpt/compat/webkit-box-horizontal-reverse-variants.html

Change-Id: Ib32dcfef7c147d2e90b754d35f974ebe9c6092b4

Reviewed-on: https://chromium-review.googlesource.com/1989930
WPT-Export-Revision: 6e7bcf088b3316c8800b9ae08eadf9d058bebdbf

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=346fe2d938eaceea6fc5f209c2402b4ecc799f2c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 1
FAIL: 2

Chrome

FAIL: 3

Safari

PASS: 2
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/compat/webkit-box-horizontal-reverse-variants.html: FAIL (Chrome: FAIL, Safari: PASS)
/compat/webkit-box-horizontal-rtl-variants.html: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b157236e5426
[wpt PR 21087] - css-deprecated-flexbox: fixes coordinates when flipped, a=testonly
https://hg.mozilla.org/integration/autoland/rev/05dda91ceb94
[wpt PR 21087] - Update wpt metadata, a=testonly

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/b157236e5426
https://hg.mozilla.org/mozilla-central/rev/05dda91ceb94