1607877 - [wpt-sync] Sync PR 21093 - Update cookie WPT expectations to support nameless cookies.

Status: RESOLVED FIXED

(Core :: Networking: Cookies, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21093 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21093
Details from upstream follow.

Mike West <[e-mail]> wrote:

Update cookie WPT expectations to support nameless cookies.

Based on the discussion in 1, we should change the spec to support
nameless cookies parsed from headers like Set-Cookie: foo. This patch
updates the WPT expectations accordingly.

Bug: 1037996
Change-Id: Iefabea524377857d524c74457153347a107401ee
Reviewed-on: https://chromium-review.googlesource.com/1982551
WPT-Export-Revision: 8e7be19fb1c8fcdf5c57f697f429e9fa5db779c5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 21093 applied with additional changes from upstream: 3adc15d3ba2e20e9ae79daf019cb784934f0fa7f

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=af9b2d2a603b75f10558e81e1f5948216874ad29

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 26[['GitHub']] 65[[u'Gecko-android-em-7.0-x86_64-debug-geckoview', u'Gecko-android-em-7.0-x86_64-opt-geckoview', u'Gecko-linux64-asan-opt', u'Gecko-linux64-debug', u'Gecko-linux64-opt', u'Gecko-linux64-qr-debug', u'Gecko-linux64-qr-opt', u'Gecko-windows10-64-debug', u'Gecko-windows10-64-opt', u'Gecko-windows10-64-qr-debug', u'Gecko-windows10-64-qr-opt', u'Gecko-windows7-32-debug', u'Gecko-windows7-32-opt']]
FAIL: 2

Chrome

OK : 1
PASS: 22
FAIL: 6

Safari

OK : 1
PASS: 17
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/cookies/http-state/general-tests.html
0024 - Ignore Set-Cookie: = with other Set-Cookie headers.: FAIL (Chrome: FAIL, Safari: FAIL)
0025 - Ignore name- and value-less Set-Cookie: ; bar.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e4add660dab
[wpt PR 21093] - Update cookie WPT expectations to support nameless cookies., a=testonly
https://hg.mozilla.org/integration/autoland/rev/7b20f05c75fc
[wpt PR 21093] - Update wpt metadata, a=testonly

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0e4add660dab
https://hg.mozilla.org/mozilla-central/rev/7b20f05c75fc