1608034 - Clean up EnvironmentObject shape teleporting code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

Environment objects are currently marked as 'delegate' and we can call PurgeEnvironmentChainHelper on them, but we no longer rely on shape teleporting of environment chains anywhere.

If we stop making them delegates we can remove/simplify PurgeEnvironmentChainHelper and fold it into PurgeProtoChain.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1608034 part 1 - Remove shape teleporting code for environment objects. r?tcampbell!

We don't rely on this anymore so we can stop marking environment objects as 'delegate'
and simplify PurgeEnvironmentChainHelper.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1608034 part 2 - Tweak FunHasExtensibleScope check in NeedEnvironmentShapeGuard. r?tcampbell!

Now that this flag is on BaseScript we don't need a non-lazy BaseScript anymore.

Depends on D59281

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/515fe2235e71
part 1 - Remove shape teleporting code for environment objects. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/6ed1ed2c7b85
part 2 - Tweak FunHasExtensibleScope check in NeedEnvironmentShapeGuard. r=tcampbell

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/515fe2235e71
https://hg.mozilla.org/mozilla-central/rev/6ed1ed2c7b85