1608071 - Rename common ancestor to closest common inclusive ancestor around `nsRange`

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1608071: part 1) Rename common ancestor to closest common inclusive ancestor around `nsRange`. r=smaug

It's more precise and enables one to reason more clearly about related
code.

Comment 2

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1608071: part 2) Rename `nsContentUtils::GetCommonAncestor` and related methods. r=smaug

Depends on D59318

Comment 3

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1608071: part 3) Rename `nsSlots::mCommonAncestorRanges` to `nsSlots::mClosestCommonInclusiveAncestorRanges`. r=smaug

Comment 4

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1608071: part 4) Rename `GetNextRangeCommonAncestor`. r=smaug

The old name was misleading.

Comment 5

[Mirko Brodesser (:mbrodesser-Igalia), offline until April 25h]

Attachment: Bug 1608071: part 5) Remove superfluous code in `nsRange::IsNodeSelected`. r=smaug

Depends on D59336

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b85dcadda9
part 1) Rename common ancestor to closest common inclusive ancestor around `nsRange`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e73fe8488d7c
part 2) Rename `nsContentUtils::GetCommonAncestor` and related methods. r=smaug
https://hg.mozilla.org/integration/autoland/rev/76ff9dd86471
part 3) Rename `nsSlots::mCommonAncestorRanges` to `nsSlots::mClosestCommonInclusiveAncestorRanges`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/29c840428360
part 4) Rename `GetNextRangeCommonAncestor`. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ab4bc0bbd2c5
part 5) Remove superfluous code in `nsRange::IsNodeSelected`. r=smaug

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/45b85dcadda9
https://hg.mozilla.org/mozilla-central/rev/e73fe8488d7c
https://hg.mozilla.org/mozilla-central/rev/76ff9dd86471
https://hg.mozilla.org/mozilla-central/rev/29c840428360
https://hg.mozilla.org/mozilla-central/rev/ab4bc0bbd2c5