1608134 - Cleanup JS opcode flags

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

This is just convenient cleanup.

• Use BytecodeEmitter::emitIndexOp/emitAtomOp more consistently
• Avoid js::CodeSpec outside of BytecodeUtil
• Add JOF_SPREAD/JOF_CONSTRUCT

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1608134 - Change argument order for BytecodeEmitter::emitAtomOp. r?arai

This makes it more consistent with other opcode emitters. No semantic changes
in this patch.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1608134 - Replace BytecodeEmitter::emitIndex32. r?arai

Remove emitIndex32 and use emitIndexOp/emitAtomOp more consistently.

Depends on D59345

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1608134 - Uses helpers when accessing js::CodeSpec. r?jandem

Remove almost all direct uses of js::CodeSpec in favour of helper functions
defined in vm/BytecodeUtil.h

Depends on D59346

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1608134 - Rename IsCallOp to IsInvokeOp. r?jandem

The function covers call, construct, and eval so the previous name was
misleading.

Depends on D59347

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1608134 - Add JOF_SPREAD/JOF_CONSTRUCT bytecode flags. r?jandem

These characteristics affect the calling conventions and what needs to be
pushed to stack so it worth being explicit about flags.

Depends on D59348

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/397cf1f6663c
Change argument order for BytecodeEmitter::emitAtomOp. r=arai
https://hg.mozilla.org/integration/autoland/rev/88dc614f2324
Replace BytecodeEmitter::emitIndex32. r=arai
https://hg.mozilla.org/integration/autoland/rev/c9c4fef81165
Uses helpers when accessing js::CodeSpec. r=jandem
https://hg.mozilla.org/integration/autoland/rev/a3a8da41ae26
Rename IsCallOp to IsInvokeOp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/60ff07dcec47
Add JOF_SPREAD/JOF_CONSTRUCT bytecode flags. r=jandem

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/397cf1f6663c
https://hg.mozilla.org/mozilla-central/rev/88dc614f2324
https://hg.mozilla.org/mozilla-central/rev/c9c4fef81165
https://hg.mozilla.org/mozilla-central/rev/a3a8da41ae26
https://hg.mozilla.org/mozilla-central/rev/60ff07dcec47