1608137 - Document and kickstart the agreed process to "suggest new or change existing metric types"

Status: RESOLVED FIXED

(Data Platform and Tools :: Glean: SDK, task, P1)

Description

[Alessio Placitelli [:Dexter]]

+++ This bug was initially created as a clone of Bug #1570386 +++

Once bug 1570386 is settled and the design is agreed upon, we need to document the outcome of our decision and implement the proposal strategy.

Comment 1

[Alessio Placitelli [:Dexter]]

Attachment: change_request_metric_type.md

This is a markdown questionnaire created from the proposal document (section "The custom bugzilla form").

This will be shown as the default form when filing a new bug in the Glean Metric Types component.

I tried to phrase the required points as question and to provide a simple example for each answer.

Comment 2

[Beatriz Rizental [:brizental]]

I think the form is very clear overall and the examples really help in understanding how to fill it.

One sentence that is not very clear to me is:

Depending on the request, only leave and fill one of the two sections below.

What is the intended meaning here? Do we have any non-required field?

And one small nit:

[...] This would make it harder to consume on available tools such as GLAM, requiring us to write custom SQL code._

Comment 3

[Alessio Placitelli [:Dexter]]

(In reply to Beatriz Rizental from comment #2)

I think the form is very clear overall and the examples really help in understanding how to fill it.

One sentence that is not very clear to me is:

Depending on the request, only leave and fill one of the two sections below.

What is the intended meaning here? Do we have any non-required field?

Oh, you're right. That's a leftover from a previous version of that file.

And one small nit:

[...] This would make it harder to consume on available tools such as GLAM, requiring us to write custom SQL code._

Fixed!

Comment 4

[Alessio Placitelli [:Dexter]]

Attachment: change_request_metric_type.md

Comment 5

[Alessio Placitelli [:Dexter]]

And this is the template to be used to drive the discussion after a new request is triaged.

Feedback is appreciated. This captures what was decided on in the proposal document, section "The discussion document". The format is intentionally very simple to allow for easier conversion to other formats in order to attach it to the bug.

Comment 6

[Alessio Placitelli [:Dexter]]

See comment 5.

Comment 7

[Beatriz Rizental [:brizental]]

Left comments in the document.

Comment 8

[Chris H-C :chutten]

Comments in the doc.

Comment 9

[Alessio Placitelli [:Dexter]]

The process doc is now publicly available on the Mozilla Wiki.

Comment 10

[Michael Droettboom [:mdroettboom]]

LGTM

Comment 11

[Alessio Placitelli [:Dexter]]

Attachment: Glean Book PR

Comment 12

[Alessio Placitelli [:Dexter]]

Note to self: before closing this bug I need to move the existing bugs to the other component.