border-image-repeat: repeat is incorrect
Categories
(Core :: Graphics: WebRender, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | verified |
People
(Reporter: nical, Assigned: nical)
Details
Attachments
(4 files)
Before patch
Look at the example at https://developer.mozilla.org/en-US/docs/Web/CSS/border-image-repeat the pattern is "squished" instead of preserving its aspect ratio as it should.
The issue is in brush_image.glsl: the stretch size is incorrectly computed in function of the uv_size, whereas it should be a function of the segment size (preserving the aspect ratio).
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Depends on D59899
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b8a27242880 Fix border-image-repeat: repeat in WebRender. r=gw https://hg.mozilla.org/integration/autoland/rev/47c89996827d Adjust reftest expectations. r=kvark
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8b8a27242880
https://hg.mozilla.org/mozilla-central/rev/47c89996827d
|
||
Updated•4 years ago
|
|
||
Comment 7•4 years ago
|
||
I tried to verify this fix, but I can't reproduce the initial issue on Nightly 74.0a1 (Build ID: 20200109094415), tried on Windows 10 x64, Ubuntu 18.04 and Mac OS X 10.15.
Nicolas, can you please confirm that the issue is fixed on your end?
|
|
Assignee | |
Comment 8•4 years ago
|
||
Verified it is fixed.
|
|
||
Comment 9•4 years ago
|
||
(In reply to Nicolas Silva [:nical] from comment #8)
Verified it is fixed.
Based on this comment, can I set the tracking flag of firefox 74 to verified?
Description
•