1608168 - Ship String.prototype.replaceAll

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, task, P1)

Description

[Mike Conca [:mconca]]

String.prototype.replaceAll landed in 72 via bug 1540021, but is restricted to Nightly due to the lack of test262 tests. Once those tests exist, this bug should enable String.prototype.replaceAll to ride the trains to release.

Comment 1

[Mike Conca [:mconca]]

Looks like tests have landed.

https://github.com/tc39/test262/tree/master/test/built-ins/String/prototype/replace

Comment 2

[Mathias Bynens]

FWIW, Safari 13.1 ships String.prototype.replaceAll: https://webkit.org/blog/10247/new-webkit-features-in-safari-13-1/

Comment 3

[Jan de Mooij [:jandem]]

What do you think, André? I'm happy to write the patch if you're busy.

Comment 4

[André Bargull [:anba]]

It should be okay to release replaceAll by default.

Comment 5

[André Bargull [:anba]]

Attachment: Bug 1608168 - Part 1: Enable String.prototype.replaceAll by default. r=jorendorff!

Comment 6

[André Bargull [:anba]]

Attachment: Bug 1608168 - Part 2: Reimport test262 to reflect changed feature flags. r=jorendorff!

Depends on D70195

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ebccccc34ec
Part 1: Enable String.prototype.replaceAll by default. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/2da7bd05e25f
Part 2: Reimport test262 to reflect changed feature flags. r=jorendorff

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/8ebccccc34ec
https://hg.mozilla.org/mozilla-central/rev/2da7bd05e25f

Comment 9

[Florian Scholz (Open Web Docs)]

Docs:
https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/77#JavaScript
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll