1608183 - Move ScopeCreationData into js::frontend namespace

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

This is a cleanup item related to Bug 1592102. When we landed ScopeCreationData it was in the js:: namespace. However, it ought to be moved to the js::frontend:: namespace to better reflect how it is used.

This Bug Is Done When:

ScopeCreationData is in the js::frontend:: namespace, and Spidermonkey compiles, and the tests pass.

Prerequisites

Before getting started, you'll want to

• You Have a checkout of the Firefox source code
• Read this walkthrough about how development works in Firefox
• Make sure you can build SpiderMonkey

Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into #jsapi on irc.mozilla.org.

Comment 1

[Rob]

I'd like to solve this issue.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Definitely feel free to produce a patch. We tend not to assign bugs until that point, just in case things happen and a contributor isn't able to get through it.

Comment 3

[Rob]

Attachment: Bug 1608183 - Move js::ScopeCreationData to js::frontend namespace r?mgaudet

Comment 4

[Rob]

Attachment: Bug 1608183 - Move js::ScopeCreationData to js::frontend namespace r?mgaudet

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5259dd26dcc7
Move js::ScopeCreationData to js::frontend namespace r=mgaudet

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on Stencil.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/3f9ac70e53fa6518dd7c6aa6c6066703e1637a9a
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284887187&repo=autoland&lineNumber=5139

Comment 7

[Rob]

If I qualify AbstractScope and GCMarker in the friend declaration with the js:: nested name specifier will that resolve it?

class ScopeCreationData {
friend class AbstractScope;
friend class GCMarker;
...

to

class ScopeCreationData {
friend class js::AbstractScope;
friend class js::GCMarker;
...

Comment 8

[Rob]

(In reply to Rob from comment #7)

If I qualify AbstractScope and GCMarker in the friend declaration with the js::frontend nested name specifier will that resolve it?

class ScopeCreationData {
friend class AbstractScope;
friend class GCMarker;
...

to

class ScopeCreationData {
friend class js::frontend::AbstractScope;
friend class js::frontend::GCMarker;
...

AbstractScope and GCMaker are part of the js::frontend namespace. Changing above to.

Comment 9

[Rob]

Found this
https://hg.mozilla.org/mozreview/gecko/file/fffb99c3715dcbe8c596f49c8c2e2f7f8f06adef/dom/canvas/WebGLProgram.h

Suggests maybe adding

frontend:: instead of js::frontend::

Thoughts?

Comment 10

[Matthew Gaudet (he/him) [:mgaudet]]

Interesting; I didn't catch this with our try build because I didn't run the windows jobs.

AbstractScope and GCMarker are just part of the js:: namespace.

I guess we should try friend class js::{AbstractScope,GCMarker}.

If you update the diff, I'll do a try push for you.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/976655426e8d
Move js::ScopeCreationData to js::frontend namespace r=mgaudet

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/976655426e8d