1608207 - Make sure TRR requests don't use the HTTP cache

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P1)

Description

[Valentin Gosu [:valentin] (he/him)]

TRR requests should bypass the HTTP cache (because of the overhead) but it seems we only do it for private browsing

Comment 1

[Valentin Gosu [:valentin] (he/him)]

So, the odd thing here is that the we only set the nsIRequest::INHIBIT_CACHING flag for private browsing. Clearly we should set it for all channels, right? In nsIRequest.idl it states: This flag prevents caching of any kind. It does not, however, prevent cached content from being used to satisfy this request. so there's still the worry that it will be looking for a cache entry, which will cause a delay.
However, it seems we also bypass the cache when Cache-Control: no-store is set, which is always (for POST requests). So probably this was only affecting GET requests, which is non-default.

I'll file a patch soon that fixes the flags so we don't cache TRR get requests either.

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1608207 - Make sure TRR requests don't use the HTTP cache r=dragana

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e86006b356a
Make sure TRR requests don't use the HTTP cache r=dragana

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/0e86006b356a