1608217 - Add innerWindowID of the current tab for the network markers

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement, P2)

Description

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Currently we have page/tab information inside some of the markers we could get. But during the initial implementation it wasn't possible to get that information from necko.
We would like to filter out network requests if they are not relevant to that tab inside the profiler front-end now. To be able to do that we should add innerWindowID inside the network markers.

Comment 1

[Honza Bambas (:mayhemer)]

ni?me: provide more information about how to carry the innerwin id from the child channel to the parent channel and expose it. some links where to start and where to expose, more details will be provided.

Comment 2

[Honza Bambas (:mayhemer)]

It looks like this information should already be available on nsIChannel.loadInfo object as nsILoadInfo.innerWindowID. nsHttpChannel as well as HttpChannelChild keep it simply as mLoadInfo.

Can you please try that?

Comment 3

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Thanks for looking into it Honza! That's great news. I will work on this as soon as I have some time. Redirecting ni to myself.

Comment 4

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Attachment: Bug 1608217 - Add innerWindowID into network markers. r?gerald

Comment 5

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

This patch should do it, it's pretty straightforward. Removing the ni now.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94cb6116eea8
Add innerWindowID into network markers. r=gerald

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/94cb6116eea8