1608246 - "Saved Addresses..." subdialog doesn't open if the window is too small

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Robin Steuber (she/her) [:bytesized]]

STR:

1. Open about:preferences
2. Reduce the size of the Firefox window to be pretty small
3. Open any subdialog. I searched for the "Saved Addresses..." button and clicked it, but I believe I have seen this bug on other subdialogs too.

Expected Results:
The dialog opens

Actual results:
The dialog does not open.
The console contains this error:TypeError: contentPane is null (subdialogs.js:434:7)

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Oops. I somehow submitted that bug in the middle of typing the title. Don't know how, but I'm fixing it now.

Comment 2

[Robin Steuber (she/her) [:bytesized]]

I updated the title and the description. I plan to take a look into this error, because I am suspicious that this may be a regression of Bug 1588142 or Bug 1601708. I'll update when I know more.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Kirk Steuber (he/him) [:bytesized] from comment #2)

I updated the title and the description. I plan to take a look into this error, because I am suspicious that this may be a regression of Bug 1588142 or Bug 1601708. I'll update when I know more.

This would be useful to know in terms of priorities, to see when this regressed and/or for what releases we need to track it. Did you find out?

Comment 4

[Robin Steuber (she/her) [:bytesized]]

I'm afraid I haven't had time to look into this yet, I'm hoping to have time for it before EOD tomorrow.

I did notice that, despite my earlier belief that this was happening in multiple subdialogs, I now only seem to get it in the one "Saved Addresses..." dialog.

Comment 5

[Robin Steuber (she/her) [:bytesized]]

This is indeed a regression resulting from my patch past bug foolishly assuming that the CSS it was changing wouldn't be applied to other pages, when in fact it is applied to many pages. I'll have a patch up shortly.

Comment 6

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 1608246 - Fixes for small subdialogs in preferences r=bgrins

Bug 1588142 introduced two problems: First, it added CSS to prefrences.css that was meant to apply only to preferences.xhtml, but in fact ends up applying to other pages. This patch fixes that.

The second problem was an assumption made in subdialogs.js that all preferences subdialogs would have either a contentPane or a <dialog> element, which we should set to be scrollable if the window is too small. It turns out that there is at least one dialog that has overflow-y set to auto, thus handling it's own scrolling. The relevant code has been updated not to make that assumption.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df97ae305b64
Fixes for small subdialogs in preferences r=bgrins

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/df97ae305b64