1608280 - Support a per-tile clip (valid) region for compositor tiles

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Glenn Watson [:gw]]

This will allow us to avoid some overdraw in cases where a large picture cache slice has holes (e.g. a slice with status bar at the bottom + main ui bar at the top).

Comment 1

[Glenn Watson [:gw]]

Attachment: Bug 1608280 - Support a per-tile clip (valid) region for compositor tiles

Comment 2

[Glenn Watson [:gw]]

Note that this doesn't pass the valid region rect to the native compositor trait yet, it is only used by the simple (WR) compositing mode. I will implement the native compositor usage of the valid region rect as a follow up.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7295ca89e880
Support a per-tile clip (valid) region for compositor tiles r=nical

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7295ca89e880

Comment 5

[Andreea Pavel [:apavel]]

Backed out for causing bugs 1608912 and 1608871

Backout: https://hg.mozilla.org/mozilla-central/rev/0690f68a8d9984d2653792e3294bf876eecef651

Comment 6

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #24671 (as of Wed, 15 Jan 2020 06:06:10 GMT) ==

Improvements:

6% glterrain windows10-64-shippable-qr opt e10s stylo 1.11 -> 1.05

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=24671

Comment 7

[Glenn Watson [:gw]]

Attachment: Bug 1608280 - Part 1 - Add a valid_rect to picture cache and composite tiles.

This patch introduces a per-tile valid rect. In the initial implementation,
this only uses the bounds of the overall picture cache bounding rect. The
next part of this patch will make use of true per-tile valid regions, to
improve performance where there are holes in a single cache slice.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42095e4b1709
Part 1 - Add a valid_rect to picture cache and composite tiles. r=mstange

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/42095e4b1709

Comment 10

[Glenn Watson [:gw]]

Attachment: Bug 1608280 - Part 2 - Use valid rect to reduce pixel costs.

With this patch, a minimal valid rect is calculated for each
picture cache tile. This is used to reduce the scissor rect
during tile rasterization, and the draw rect during tile
compositing, whenever there is a partial tile.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b174d2f9072d
Part 2 - Use valid rect to reduce pixel costs. r=kvark

Comment 12

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/b174d2f9072d