1608456 - [wpt-sync] Sync PR 21134 - In order to get a preciser aspect-ratio, change parseInt to parseFloat

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 21134 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/21134
Details from upstream follow.

Cathie Chen <[e-mail]> wrote:

In order to get a preciser aspect-ratio, change parseInt to parseFloat

Hi,
When getComputedStyle(images[5]).width is 100px, the used value of getComputedStyle(images[5]).height is float(79.69924812030075).
Using parseFloat instead of parseInt can make the calculate aspect-ratio closer to the actual one.

PTAL, thanks:)

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1165c24f45a4bbdabeaf6e96b753d9ce9d021d5e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 40 tests

Status Summary

Firefox

OK : 1
PASS: 39
FAIL: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio.html
Image width and height attributes are used to infer aspect-ratio: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e47be646e6b
[wpt PR 21134] - In order to get a more precise aspect-ratio, change parseInt to parseFloat, a=testonly

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3e47be646e6b