1608523 - Add optional start time for a MOZ_LOG message

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

With the ability to pump log messages into the profiler (MOZ_LOG=...,profilermarkers) being able to provide a time period associated with the message can be useful (and this is frequently used with Text and other markers in the profiler, like the DocumentLoad marker, or DomContentLoaded, etc).

I propose a parallel entry for logging (MOZ_LOG_TIME(), though it could be renamed) which takes an optional start time. We could also be fully explicit and allow/require start and end times when using this API.

For text output, we could include a time range (similar to how we add timestamps for "MOZ_LOG=...,timestamp")

To maximize speed and minimize codesize at callpoints, I've implemented it as largely parallel to the MOZ_LOG calls except at the lowest level (::Print() in logging.cpp). We could merge the two versions at a higher level instead.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

an output line would look like this:
2020-01-10 19:20:50.997112 -> 19:20:50.999092 UTC (2ms)- [(null) 14778: Main Thread]: D/nsHttp nsHttpChannel::DoConnect [this=0x82f06000, aTransWithStickyConn=0x0]

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1608523: Add MOZ_LOG_TIME() to allow time ranges for logs r=froydnj

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ac2664e023ce
Add MOZ_LOG_TIME() to allow time ranges for logs r=froydnj

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ac2664e023ce