1608545 - Opening a new tab in the same container doesn't work

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

In the last couple of days when I am in a non default container and I open a new tab using Cmd-Click on the new tab button (+) the tab gets the correct container indicator, but the page opens with the credentials in my default container. My typical use case is with GDocs, but I notice it with other sites, too.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

I am seeing this on macOS, if that's useful. I haven't tested in other platforms yet.

Comment 2

[Timea Cernea [:tbabos][inactive]]

Reproduced on the latest Nightly 74 on Windows 10 x64. Updating affected flags and looking into the regression range.
Beta and Release are unaffected.

Comment 3

[Timea Cernea [:tbabos][inactive]]

15:27.23 INFO: Got as far as we can go bisecting nightlies...
15:27.23 INFO: Last good revision: e6427fac5ee8d1d87fb78e917781e85dda119a81 (2020-01-06)
15:27.23 INFO: First bad revision: e728bf01a2b60414e18ac3abed8af55d5ab35924 (2020-01-07)
15:27.23 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e6427fac5ee8d1d87fb78e917781e85dda119a81&tochange=e728bf01a2b60414e18ac3abed8af55d5ab35924

Can't bisect further due to mozregression error.

Comment 4

[Timea Cernea [:tbabos][inactive]]

Actually, managed to bisect further:
Narrowed inbound regression window from [f56289d7, ead1aea2] (3 builds) to [f56289d7, ea61d93b] (2 builds) (~1 steps left)
2020-01-15T16:15:01: DEBUG : Starting merge handling...
2020-01-15T16:15:01: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=ea61d93b261638d675374e209c5937f6542f2bbb&full=1
2020-01-15T16:15:02: DEBUG : Found commit message:
Bug 1242912, batch insert tabs during a session restore instead of adding tabs individually. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D53692

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1608545 - ensure userContextId inherited from relatedTab is used throughout addTab and test for it, r?dao

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a51e1a67ed2e
ensure userContextId inherited from relatedTab is used throughout addTab and test for it, r=dao

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a51e1a67ed2e