1608579 - Disable double buffering on 72

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

We want to do this because of bug 1608485

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1608579. Turn off double buffering in 72. a=lizzard

We have reports of 60fps video stutter caused by
double buffering so let's disable it until we can figure
out what's going on.

This is the same thing that landed in 71: 2dd6b102980e

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9120201 [details]
Bug 1608579. Turn off double buffering in 72. a=lizzard

Beta/Release Uplift Approval Request

• User impact if declined: 60fps video stutter
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Multiple reporters confirmed that disabling double-buffering helps with their problem.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just reverting to the same behaviour we had in 71
• String changes made/needed:

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Looking to get this into a potential 72.0.2 dot release.

Comment 4

[Julien Cristau [:jcristau]]

Comment on attachment 9120201 [details]
Bug 1608579. Turn off double buffering in 72. a=lizzard

turn double buffering back off to fix video regression on some hw, approved for 72.0.2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/6e8e9ccb6bf4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Given where we are in the cycle, should we consider taking this on Beta for 73 as well?

Comment 7

[Julien Cristau [:jcristau]]

And possibly also trunk until there's a fix for bug 1608485?

Comment 8

[Jeff Muizelaar [:jrmuizel]]

We can uplift for 73 in bug 1610912