1608588 - Restrict notification permission prompts (just like on desktop)

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[Andreas Bovens [:abovens]]

Attachment: Screenshot_20200110-200231.jpg

In Firefox 72 for desktop, we made a change requiring explicit user interaction on all notification permission prompts. GeckoView should respect this as well.

See https://hacks.mozilla.org/2019/11/upcoming-notification-permission-changes-in-firefox-72/

Example: load https://www.livescience.com/hidden-impact-crater-laos.html in Firefox Preview, and a notification prompt is shown on initial page load. This shouldn't happen.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1608588 - Auto-deny `desktop-notification` permission appropriately

This causes us to automatically deny the desktop-notification
permission if there is no user interaction, like desktop Firefox. This is
not enforced if the dom.webnotifications.requireuserinteraction
preference is set to false

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8eb2b7857f62
Auto-deny `desktop-notification` permission appropriately r=geckoview-reviewers,esawin

Comment 3

[Cristina Coroiu [:ccoroiu]]

Backed out changeset 8eb2b7857f62 (bug 1608588) for ESlint failure at mobile/android/components/geckoview/GeckoViewPermission.js

Backout: https://hg.mozilla.org/integration/autoland/rev/fb6b61e49217d835b2d6e435560424aab10d5475

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=8eb2b7857f623295acf2ae294d925722a804d45a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286161117&repo=autoland&lineNumber=332

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ef356b5b0879
Auto-deny `desktop-notification` permission appropriately r=geckoview-reviewers,esawin

Comment 5

[Cristina Coroiu [:ccoroiu]]

Backed out changeset ef356b5b0879 (bug 1608588) for junit failures

Backout: https://hg.mozilla.org/integration/autoland/rev/7bf64babe84a7c66c58eaca25635127582226b4a

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ef356b5b0879677a254143aef161d946feb23e5e

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=286181901&repo=autoland&lineNumber=6773

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f044fd80361
Auto-deny `desktop-notification` permission appropriately r=geckoview-reviewers,esawin

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2f044fd80361