1608648 - Apply prefer-colors-scheme

Status: RESOLVED DUPLICATE of bug 1505090

(DevTools :: Shared Components, enhancement)

Description

[mcnesium]

Attachment: Screenshot from 2020-01-11 18-53-51.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:72.0) Gecko/20100101 Firefox/72.0

Steps to reproduce:

When having a dark theme in the OS, Firefox correctly applies any @media (prefers-color-scheme: dark) rules on websites, in other words: makes websites appear dark too. Examples: duckduckgo.com and bugzilla.mozilla.org.

Actual results:

The devtools do not turn dark, even though there is a dark theme available.

Expected results:

The devtools should also turn dark, if dark mode is prefered

Comment 1

[Milek Agrawal]

@ ladybenko can you please assign me this task. I am working on it.

Comment 2

[Milek Agrawal]

(In reply to Milek Agrawal from comment #1)

@ ladybenko can you please assign me this task. I am working on it. Also can you please guide me on how to find the code snippet related to an issue in searchfox.org.

Comment 3

[Belén [:ladybenko]]

Pinging Victoria, because I'm not sure if we actually want to do this. And if we do, we need to think what to do about the theme radio buttons in settings (maybe add a "OS default" option?).

can you please guide me on how to find the code snippet related to an issue in searchfox.org.

Milek, I'm not sure what are you asking exactly. Searchfox has a top searchbox in which you can search for fragments of code. On the right side, you will find another input to filter by file path (i.e. typing devtools there will narrow the results to mozilla-central/devtools)

Comment 4

[mcnesium]

@ladybenko why would you not want to do this? I understand that it does not work yet because the devtools had their own theme management, because lots of devs prefer dark backgrounds in general, and the demand for occasional switching between dark and light UI themes is rather new for most users. But an active decision to not have the devtools UI behave in sync with the rest of the browser UI would feel strange to me.

I agree on the proposal to have an "OS default" radio button set as the default.

Comment 5

[Victoria Wang [:victoria]]

Sorry for the delay in responding!

So, I see that if you're on the Default Firefox theme in MacOS, the browser UI does change to dark based on OS change. (If Light or Dark themes are specified, they remain unchanged.)

An extra radio button for "OS default" seems good to me. We can default to this in Stable/Nightly, but in DevEdition I think we'd still default to Dark.

CCing Harald in case he has thoughts.

Comment 6

[:Harald Kirschner :digitarald]

If I am not missing something, this is the same discussion as bug 1505090, right?

Comment 7

[:Harald Kirschner :digitarald]

(re-open in case this covers some more specific aspect)