1608651 - All extensions crashing on window.open() and privacy.firstparty.isolate;true after 1590032

Status: NEW

(Core :: DOM: Security, defect, P3)

Description

[John]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Create new profile
2. Set privacy.firstparty.isolate;true on about:config page
3. Install uMatrix (1.4.0) from
   https://addons.mozilla.org/firefox/addon/umatrix/
4. Open this page
   http://www.gtalbot.org/FirefoxSection/Popup/PopupAndFirefox.html
   and click "Open a requested popup" in "Interactive demo" section
5. Click on uMatrix icon in urlbar and see blank popup

After that all addons not working on my main profile, include simple addons like https://addons.mozilla.org/firefox/addon/minimize-the-window/

Mozregression pointed on this
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=e832b3b54e4919b969ea871f8745bace7c6b7ac1&tochange=4a0dc82465d2a8d7ca6bc66371310081d07a774a

Comment 1

[John]

Sorry, forgot to specify platform: Kubuntu 18.04.3 LTS x86_64.

Comment 2

[Gary Chen [:xeonchen]]

Tim, based on the mozregress result, would you check this?

Comment 3

[Pascal Chevrel:pascalc]

Tim, what is the status of this P1 wrt 74? Thanks

Comment 4

[Tim Huang[:timhuang]]

I am working on this. But, I haven't found the root cause. So, I don't think I can fix this in 74.

Comment 5

[Tim Huang[:timhuang]]

Attachment: Bug 1608651 - Don't propagate the firstPartyDomain in OriginAttributes if the owner has the system principal. r?smaug

This patch stops the propagation of the firstPartyDomain through opener
if the opened window has the system principal. This is for the case that
the ViewPopup of the web extnesion would have a content window as its
opener, but it is opened in a system window. We should stop propagate
the firstPartyDomain in this case. Or Firefox would crash in a
originAttributes check afterward.

Comment 6

[Ethan Tseng [:ethan]]

Marking 75 and 76 as disabled because this feature (privacy.firstparty.isolate) is off by default.
(However, a few extensions would enable it.)

Comment 7

[Pascal Chevrel:pascalc]

Tim, there is a patch in this bug, are you planning to land it? Thanks

Comment 8

[Tim Huang[:timhuang]]

Yes, I want to land the patch. But, this patch needs to be updated and I haven't had time to do it. I will start to finish it.

Comment 9

[Emma Malysz]

Tim, do you plan on taking a look at this again?

Comment 10

[Tim Huang[:timhuang]]

I don't plan to fix this bug in the near future. I think I should unassign myself from this bug.

Comment 11

[Dianna Smith [:diannaS]]

:ckerschb Since privacy.firstparty.isolate is still off by default, should this still be an S2 ticket?

Comment 12

[Tim Huang[:timhuang]]

I think S3 would be good for this. I will take the bug again to see if I can fix this right.