1608765 - Rotated day and week views are broken

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: Screenshot from 2020-01-13 21-55-55.png

The time bar is still displayed vertically instead of horizontally, and everything else is squashed at the bottom, off-screen.

Comment 1

[Stefan Sitter [:ssitter]]

Is only Lightning 74 affected? Or older versions too? Do you get any error messages in console?

Comment 2

[Geoff Lankow (:darktrojan)]

Looks fine on 73. No error messages, this is some sort of layout SNAFU. I wonder if mozilla-central changed something or if we just broke it.

Comment 3

[Richard Marti (:Paenglab)]

Probably also a fallout of bug 1606130.

Comment 4

[Magnus Melin [:mkmelin]]

STR: In calendar view, go to View | Calendar | Current View | Rotate View
Notice things look weird, like in attachment 9120398 [details]

Alice, can you help find what broke it?

Comment 5

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=b4e1c22a54e49886946f3390c7369b1e5a1ce27c&tochange=e60c7640c9731b8be5780ceb72ad3c83784958cb
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e728bf01a2b60414e18ac3abed8af55d5ab35924&tochange=12fb5e522dd32b5ff50c8196c05b3ba9d244417e

Comment 6

[Magnus Melin [:mkmelin]]

Thanks! Some of the changes from mozilla-central then.

Comment 7

[Magnus Melin [:mkmelin]]

Confirmed by local backout this is from https://hg.mozilla.org/mozilla-central/rev/be0ddae5d705b31965fed36688abb0167d56bfdd

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: 1608765-rotated-views-1.diff

This fixes the immediate problem. I believe there was an existing minor issue with the columns not expanding to fill the space available at start-up, but I'm not attempting to fix that here.

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: 1608765-rotated-views-tests-1.diff

This removes the duplication of the recurrence tests and instead runs the same tests twice with different parameters. It's not necessary to have two very similar sets of tests.

Comment 10

[Paul Morris [:pmorris]]

Comment on attachment 9134991 [details] [diff] [review]
1608765-rotated-views-1.diff

Review of attachment 9134991 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good, back to XUL for the moment.  I applied the patch and saw that it does fix the issue.

Comment 11

[Paul Morris [:pmorris]]

Comment on attachment 9134992 [details] [diff] [review]
1608765-rotated-views-tests-1.diff

Review of attachment 9134992 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!  Great to de-dupe these files.  I ran the tests locally and they ran and succeeded for both rotated and non-rotated views.  r+ with one comment to address.

::: calendar/test/browser/recurrence/browser_annual.js
@@ +20,5 @@
>    switchToView,
>  } = ChromeUtils.import("resource://testing-common/mozmill/CalendarUtils.jsm");
>  
>  var controller = mozmill.getMail3PaneController();
> +var { eid, getEventBoxPath, lookup, lookupEventBox } = helpersForController(controller);

Looks like this "eid" is not needed since it's unused here and similarly in the other files, unless I'm missing something.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a9db14ef8380
Fix layout of rotated calendar views. r=pmorris
https://hg.mozilla.org/comm-central/rev/1ea5b27c6245
Remove duplication of tests for recurrence. r=pmorris

Comment 13

[Geoff Lankow (:darktrojan)]

Pushed with comment addressed, and some other unused variables removed.