Closed Bug 1608774 Opened 4 years ago Closed 4 years ago

Crash in [@ neqo_http3::connection::Http3Connection<T>::check_connection_events<T>]

Categories

(Core :: Networking: HTTP, defect, P1)

Unspecified
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla74
Tracking Status
firefox-esr68 --- unaffected
firefox72 --- wontfix
firefox73 --- wontfix
firefox74 --- fixed

People

(Reporter: gsvelto, Assigned: grover)

References

(Blocks 1 open bug)

Details

(Keywords: crash, Whiteboard: [necko-triaged])

Crash Data

This bug is for crash report bp-527ddadf-3b96-48e3-b555-9d2340200110.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn src/libcore/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook src/libstd/panicking.rs:477
4 xul.dll std::panicking::begin_panic<str*> src/libstd/panicking.rs:407
5 xul.dll neqo_http3::connection::Http3Connection<neqo_http3::client_events::Http3ClientEvents, neqo_http3::transaction_client::TransactionClient, neqo_http3::connection::Http3ClientHandler>::check_connection_events<neqo_http3::client_events::Http3ClientEvents, neqo_http3::transaction_client::TransactionClient, neqo_http3::connection::Http3ClientHandler> third_party/rust/neqo-http3/src/connection.rs
6 xul.dll neqo_http3::connection_client::Http3Client::process_http3 third_party/rust/neqo-http3/src/connection_client.rs
7 xul.dll mozilla::net::Http3Session::ProcessOutput netwerk/protocol/http/Http3Session.cpp:399
8 xul.dll mozilla::net::Http3Session::Process netwerk/protocol/http/Http3Session.cpp:363
9 xul.dll mozilla::net::nsHttpConnection::EnsureNPNCompleteHttp3 netwerk/protocol/http/nsHttpConnection.cpp:749

This is a very low-volume crash tripping on this assertion:

https://hg.mozilla.org/mozilla-central/annotate/374a48ce8690a53e44ef3f4134b8ecd8099bea14/third_party/rust/neqo-http3/src/connection.rs#l450

It's been going on for a while even though the volume is very low so it might be a valid issue, especially since the stacks are consistent across versions.

Andy, can you take a look?

Assignee: nobody → agrover
Priority: -- → P1
Whiteboard: [necko-triaged]
Flags: needinfo?(agrover)

this is probably fixed by the neqo update. the update landed on 9th, last crashes are on 9th, but the nightly did not contain the update.
let's keep the bug open for a bit.

Blocks: QUIC

No more crashes in nightly after the 9th. (some in beta/release but they end Jan 19). I think this one is resolved.

Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(agrover)
Resolution: --- → FIXED
Target Milestone: --- → mozilla74
Crash Signature: [@ neqo_http3::connection::Http3Connection<T>::check_connection_events<T>] → [@ neqo_http3::connection::Http3Connection<T>::check_connection_events<T>] [@ neqo_http3::connection::Http3Connection<T>::check_connection_events]
You need to log in before you can comment on or make changes to this bug.