Enable chunking in the taskgraph for xpcshell
Categories
(Firefox Build System :: Task Configuration, task, P2)
Tracking
(firefox74 fixed)
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: ahal, Assigned: ahal)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
In bug 1583353 we started chunking test suites in the taskgraph (rather than at test runtime). Though I only enabled it for a subset of suites.
This bug tracks getting xpcshell enabled. To enable taskgraph chunking, remove the suite from this config:
https://searchfox.org/mozilla-central/rev/dd1dafd5c9c05640e76af30b58749076e0199704/taskcluster/taskgraph/transforms/tests.py#1280
I normally like to test that we still run the same set of tests before and after. To do this I:
- Push to try scheduling all tests in the suite, both with and without this change.
- Clone https://github.com/mozilla/ci-recipes and follow installation instructions.
- Run
poetry run adr compare_pushes --branch try -r1 <rev1> -r2 <rev2> - It will take awhile (~10-20min).
- Make sure the output says all tasks are the same. If the output shows one task ran more manifests than another, then we need to investigate.
To understand why it wasn't enabled already, see:
https://bugzilla.mozilla.org/show_bug.cgi?id=1583353#c57
|
Assignee | |
Comment 1•4 years ago
|
||
Oh wait a second.. I mixed up my try pushes. It's the baseline push (i.e without my changes) that is timing out with 90+ minute tasks. Any my changes are the ones that fix the issue :p.
Without my change: X1 -> 90+ min, X2 -> 14 min,
With my change: X1 -> 26 min, X2 -> 22 min
I have no idea why the total runtimes don't match up.. I'll do some more digging. It's worth noting that the timings on central for these chunks are similarly lopsided, though they don't quite hit the 90min threshold (X1->84min, X2->14min).
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
|
|
Assignee | |
Comment 3•4 years ago
|
||
|
|
Assignee | |
Comment 4•4 years ago
|
||
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b2997bfbd74 [taskgraph] Add 'ccov' to the mozinfo guess when chunking tests, r=gbrown https://hg.mozilla.org/integration/autoland/rev/43519e626b3f Update test runtimes files, r=gbrown https://hg.mozilla.org/integration/autoland/rev/a45dc9a8fcc0 [ci] Chunk xpcshell in the taskgraph, r=gbrown
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5b2997bfbd74
https://hg.mozilla.org/mozilla-central/rev/43519e626b3f
https://hg.mozilla.org/mozilla-central/rev/a45dc9a8fcc0
Description
•