1608892 - Update DTLS 1.3 to draft-34

Status: RESOLVED FIXED

(NSS :: Libraries, enhancement, P1)

Description

[Kevin Jacobs [:kjacobs]]

DTLS 1.3 implementation is at draft-30 as of https://hg.mozilla.org/projects/nss/rev/8b7f0180c5b05870c67fcc06338749e42863c74f

This bug tracks the next update to draft-34 (currently latest).

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1608892 - Update DTLS 1.3 to draft-34

This patch updates the DTLS 1.3 implementation to draft-34. Notable changes:

1. Key separation via ssl_protocol_variant.
2. No longer apply sequence number masking when in UNSAFE_FUZZER_MODE. This allowed removal of workarounds for unpadded (<16B) ciphertexts being used as input to SSL_CreateMask.
3. Compile ssl_gtests in UNSAFE_FUZZER_MODE iff --fuzz=tls was specified. Currently all gtests are compiled this way if --fuzz, but lib/ssl only if --fuzz=tls. (See above, we can't have ssl_gtests in fuzzer mode, but not lib/ssl, since the masking mismatch will break filters).
4. Parameterize masking tests, as appropriate.
5. Reject non-empty legacy_cookie, and test.
6. Reject ciphertexts <16B in length in dtls13_MaskSequenceNumber (if not UNSAFE_FUZZER_MODE).

Comment 2

[Kevin Jacobs [:kjacobs]]

https://hg.mozilla.org/projects/nss/rev/52a75c5373ef6eaf51a38568bf9c9d2f9225813a