Open Bug 1608897 Opened 5 years ago Updated 4 years ago

[github] Build status for a commit on one branch overwrites the build status of the same commit from another branch

Categories

(Taskcluster :: Services, defect)

defect
Not set
normal

Tracking

(Not tracked)

People

(Reporter: marco, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

I have two branches, testing and production, which are sometimes pointing to the same commit.
The "push" status links to the Taskcluster group which was last triggered.
E.g. if I push to testing and then to production, it will link to the build for the commit on the production branch.
If I push to production and then to testing, it will link to the build for the commit on the testing branch.

This is a feature/bug of GitHub's treatment of statuses (and checks, actually). They are tied to sha's.

I think Travis works around this by using a different status name for pushes and pull requests, so e.g., you'd get "Travis-CI (push)" and "Travis-CI (pull request)", but I don't think even that would differentiate pushes to different branches.

Taskcluster also adds the event name, e.g. "Taskcluster (push)". What if it added the branch name too (when it is not master)?
E.g. you would have "Taskcluster (testing push)" if the branch is testing, "Taskcluster (production push)" if the branch is production, "Taskcluster (push)" if the branch is master.

Owlish, what do you think?

It might help for the TC monorepo, too :)

Flags: needinfo?(bugzeeeeee)

I think that can be done for sure. This can be a good-first-bug

Flags: needinfo?(bugzeeeeee)
Mentor: bugzeeeeee
Keywords: good-first-bug
Blocks: github-bugs
Summary: Build status for a commit on one branch overwrites the build status of the same commit from another branch → [github] Build status for a commit on one branch overwrites the build status of the same commit from another branch
Mentor: bugzeeeeee
You need to log in before you can comment on or make changes to this bug.