1608911 - Reporting API should send a *collection* of reports to endpoint

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Description

[Arno Renevier]

When a feature violation is reported, a request is sent to the endpoint with the following json:

{
"age": 1002,
"type": "feature-policy-violation",
"url": "http://localhost/reporting.php",
"user_agent":+"Mozilla/5.0+(X11;+Linux+x86_64;+rv:74.0)+Gecko/20100101+Firefox/74.0",
"body": {
"featureId": "geolocation",
"sourceFile": "http://localhost/reporting.php",
"lineNumber": 8,
"columnNumber": 22,
"disposition":+"enforce"
}
}

But according to Reporting API specification, a collection of report should be sent. Which means that this report, even when submitted individually, should be enclosed within []

Comment 1

[Arno Renevier]

Attachment: Bug 1608911 - Send reports to endpoint as a collection.

In order to respect the specification, we need to send the reports as a collection.

This gives us the opportunity to group reports by endpoints and principal. That
way, if we have multiple reports to send to the same endpoint, we can do it
with only one request.

Comment 2

[Arno Renevier]

Attachment: Bug 1608911 - Send reports to endpoint as a collection.

In order to respect the specification, we need to send the reports as a collection.

This gives us the opportunity to group reports by endpoints and principal. That
way, if we have multiple reports to send to the same endpoint, we can do it
with only one request.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8cf21968b97
Send reports to endpoint as a collection. r=baku

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset a8cf21968b97 (Bug 1608911) for build bustages at ReportDeliver.cpp.
https://hg.mozilla.org/integration/autoland/rev/63280d3b908378a587b7d189982497ba8a5b661f

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=a8cf21968b9757a7929dfd1085c911652764a587&selectedJob=284912230

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=284912230&repo=autoland&lineNumber=40626

Comment 5

[Arno Renevier]

The bug was due to a typo inside a MOZ_ASSERT()
(which is why I didn't catch it on my build).

I have pushed a new patch.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31fb9b1aa4b1
Send reports to endpoint as a collection. r=baku

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/31fb9b1aa4b1