1608969 - Support ARIA comment role

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P3)

Description

[Aaron Leventhal]

A new role in ARIA called "comment" is intended to help support ARIA annotations. It maps to IA2_ROLE_COMMENT. The ARIA spec PR for it is https://github.com/w3c/aria/pull/1135.

It is currently implemented in Chrome behind the flag
--enable-features=AccessibilityExposeARIAAnnotations

It should automatically compute its level, setsize and posinset when not provided.
The level is based on counting comment ancestors until the root.

Comment 1

[James Teh [:Jamie]]

In case it's useful, here's the code in Chromium to deal with level calculation for comments:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/accessibility/ax_node_object.cc?q=kcomment+file:blink+file:ax_node&sq=package:chromium&l=1499

Comment 2

[Marco Zehe (:MarcoZ)]

Attachment: Bug 1608969 - Add new ARIA 1.3 comment role, r=jamie

This adds both the role as well as calculation of the posinset, setsize, and level calculation if not provided by the author.

Depends on D64546

Comment 3

[Marco Zehe (:MarcoZ)]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=16cd9c1e8e16ad972bbe094bf1dba19558133315

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7d85323b609
Add new ARIA 1.3 comment role, r=Jamie

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/f7d85323b609

Comment 6

[Marco Zehe (:MarcoZ)]

Has a test in the test suite, doesn't need manual testing. ATs such as NVDA don't support these roles yet anyway, so the only way would be by way of the a11y inspector. Setting QE Verify to No.

Comment 7

[Chris Mills [:cmills]]

Documentation complete; see https://github.com/mdn/sprints/issues/2939#issuecomment-607404699 for the full details.