1608985 - Denied onLoadRequest still loaded

Status: RESOLVED FIXED

(GeckoView :: General, defect, P1)

Description

[Roger Yang [:royang]]

URL was denied though onLoadRequest using AllowOrDeny.DENY return value. However, the URL is still loaded in GeckoView. Debugging Android Components seems to show that either the DENY return was ignored or there was a reload of the URL without going through onLoadRequest.

To reproduce:

1. In Fenix, turn on Settings -> Open links in apps
2. Google search "Obama youtube".
3. Tap on one of the search result.
4. YouTube app is launched and the video page is shown.
5. Switch to Fenix

Expected result:
Fenix is showing the Google search result.

Actual result:
Fenix is showing the m.youtube.com page.

Comment 1

[Emily Toop (:fluffyemily)]

Investigate.

Comment 2

[Eugen Sawin [:esawin]]

Attachment: Bug 1608985 - [1.0] Veto redirect when loading is denied by the delegate.

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Bug 1608985 - [2.0] Add LoadRequest debug string.

Depends on D61703

Comment 4

[Eugen Sawin [:esawin]]

Attachment: Bug 1608985 - [3.0] Add denied redirect test.

Depends on D61704

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a5f54eab2ac
[1.0] Veto redirect when loading is denied by the delegate. r=smaug
https://hg.mozilla.org/integration/autoland/rev/e7602052f14b
[2.0] Add LoadRequest debug string. r=geckoview-reviewers,snorp
https://hg.mozilla.org/integration/autoland/rev/ac23d692cfea
[3.0] Add denied redirect test. r=geckoview-reviewers,snorp

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a5f54eab2ac
https://hg.mozilla.org/mozilla-central/rev/e7602052f14b
https://hg.mozilla.org/mozilla-central/rev/ac23d692cfea